Skip to content

Commit ea2d9ea

Browse files
committed
Merge branch 'aoberoi-issue-53'
2 parents 72f2aa1 + f32a368 commit ea2d9ea

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

DEVELOPING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ In order to create a release, the following should be completed in order.
3030
- sample/HelloWorld/composer.json
3131
- sample/Archiving/composer.json
3232
- README.md
33+
- tests/OpenTok/OpenTokTest.php
34+
- tests/OpenTok/ArchiveTest.php
3335
1. Commit the version number change with the message "Update to version x.x.x", substituting the new version number.
3436
1. Create a git tag: `git tag -a vx.x.x -m "Release vx.x.x"`
3537
1. Change the version number for future development by adding "-alpha.1" in each file, then make another commit with the

tests/OpenTok/ArchiveTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public function testStopsArchive()
104104
// TODO: test the dynamically built User Agent string
105105
$userAgent = $request->getHeader('User-Agent');
106106
$this->assertNotEmpty($userAgent);
107-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
107+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
108108

109109
// TODO: test the properties of the actual archive object
110110
$this->assertEquals('stopped', $this->archive->status);
@@ -147,7 +147,7 @@ public function testDeletesArchive()
147147
// TODO: test the dynamically built User Agent string
148148
$userAgent = $request->getHeader('User-Agent');
149149
$this->assertNotEmpty($userAgent);
150-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
150+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
151151

152152
$this->assertTrue($success);
153153
// TODO: assert that all properties of the archive object were cleared

tests/OpenTok/OpenTokTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function testFailsOnInvalidInitialization()
5454
// Assert
5555
}
5656

57-
public function testCreatesMediaRouterAndLocationSession()
57+
public function testCreatesMediaRoutedAndLocationSession()
5858
{
5959
// Arrange
6060
$mock = new MockPlugin();
@@ -87,7 +87,7 @@ public function testCreatesMediaRouterAndLocationSession()
8787
// TODO: test the dynamically built User Agent string
8888
$userAgent = $request->getHeader('User-Agent');
8989
$this->assertNotEmpty($userAgent);
90-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
90+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
9191

9292
$location = $request->getPostField('location');
9393
$this->assertEquals('12.34.56.78', $location);
@@ -136,7 +136,7 @@ public function testCreatesMediaRelayedSession()
136136
// TODO: test the dynamically built User Agent string
137137
$userAgent = $request->getHeader('User-Agent');
138138
$this->assertNotEmpty($userAgent);
139-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
139+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
140140

141141
$p2p_preference = $request->getPostField('p2p.preference');
142142
$this->assertEquals('enabled', $p2p_preference);
@@ -314,7 +314,7 @@ public function testStartsArchive()
314314
// TODO: test the dynamically built User Agent string
315315
$userAgent = $request->getHeader('User-Agent');
316316
$this->assertNotEmpty($userAgent);
317-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
317+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
318318

319319
$body = json_decode($request->getBody());
320320
$this->assertEquals($sessionId, $body->sessionId);
@@ -360,7 +360,7 @@ public function testStopsArchive()
360360
// TODO: test the dynamically built User Agent string
361361
$userAgent = $request->getHeader('User-Agent');
362362
$this->assertNotEmpty($userAgent);
363-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
363+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
364364

365365
$this->assertInstanceOf('OpenTok\Archive', $archive);
366366
// TODO: test the properties of the actual archive object
@@ -400,7 +400,7 @@ public function testGetsArchive()
400400
// TODO: test the dynamically built User Agent string
401401
$userAgent = $request->getHeader('User-Agent');
402402
$this->assertNotEmpty($userAgent);
403-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
403+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
404404

405405
$this->assertInstanceOf('OpenTok\Archive', $archive);
406406
// TODO: test the properties of the actual archive object
@@ -442,7 +442,7 @@ public function testDeletesArchive()
442442
// TODO: test the dynamically built User Agent string
443443
$userAgent = $request->getHeader('User-Agent');
444444
$this->assertNotEmpty($userAgent);
445-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
445+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
446446

447447
$this->assertTrue($success);
448448
// TODO: test the properties of the actual archive object
@@ -479,7 +479,7 @@ public function testListsArchives()
479479
// TODO: test the dynamically built User Agent string
480480
$userAgent = $request->getHeader('User-Agent');
481481
$this->assertNotEmpty($userAgent);
482-
$this->assertStringStartsWith('OpenTok-PHP-SDK/dev-modernization', $userAgent->__toString());
482+
$this->assertStringStartsWith('OpenTok-PHP-SDK/2.2.1-alpha.1', $userAgent->__toString());
483483

484484
$this->assertInstanceOf('OpenTok\ArchiveList', $archiveList);
485485
// TODO: test the properties of the actual archiveList object and its contained archive

0 commit comments

Comments
 (0)