increase test coverage

Author: SecondeJK

src/OpenTok/Util/Validators.php

@@ -428,6 +428,11 @@ public static function validateLayoutClassListItem($layoutClassList)
         if (!is_array($layoutClassList)) {
             throw new InvalidArgumentException('Each element in the streamClassArray must have a layoutClassList array.');
         }
+
+        if (!isset($layoutClassList['layoutClassList'])) {
+            throw new InvalidArgumentException('layoutClassList not set in array');
+        }
+
         if (!is_array($layoutClassList['layoutClassList'])) {
             throw new InvalidArgumentException('Each element in the layoutClassList array must be a string (defining class names).');
         }

tests/OpenTokTest/LayoutTest.php

@@ -3,6 +3,7 @@
 namespace OpenTokTest;
 
 use OpenTok\Layout;
+use OpenTok\Util\Validators;
 use PHPStan\Testing\TestCase;
 
 class LayoutTest extends TestCase
@@ -21,6 +22,14 @@ public function testStylesheetIsNotInSerializedArrayIfNotCustom()
         }
     }
 
+    public function testWillValidateLayout(): void
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $object = ['bestFit' => true];
+
+        Validators::validateLayout($object);
+    }
+
     public function testStylesheetIsInSerializedArrayIfCustom()
     {
         $layout = Layout::createCustom(['stylesheet' => 'foo']);

tests/OpenTokTest/Validators/ValidatorsTest.php

@@ -72,28 +72,28 @@ public function testWillPassCorrectForceMutePayload(): void
         Validators::validateForceMuteAllOptions($options);
     }
 
-    public function testIsAssocWithValidArray(): void
+    public function testIsAssocWithIndexedArray(): void
     {
-        $haystack = [
-            'one' => '1',
-            'two' => '2',
-            'three' => '3',
-            'four' => '4'
-        ];
+        $array = [1, 2, 3, 4];
+        $this->assertFalse(Validators::isAssoc($array));
+    }
 
-        $this->assertTrue(Validators::isAssoc($haystack));
+    public function testIsAssocWithAssociativeArray(): void
+    {
+        $array = ['a' => 1, 'b' => 2, 'c' => 3];
+        $this->assertTrue(Validators::isAssoc($array));
     }
 
-    public function testIsAssocWithInvalidArray(): void
+    public function testIsAssocWithMixedKeysArray(): void
     {
-        $haystack = [
-            'one',
-            'two',
-            'three',
-            'four'
-        ];
+        $array = [1, 'a' => 2, 3];
+        $this->assertTrue(Validators::isAssoc($array));
+    }
 
-        $this->assertFalse(Validators::isAssoc($haystack));
+    public function testIsAssocWithEmptyArray(): void
+    {
+        $array = [];
+        $this->assertFalse(Validators::isAssoc($array));
     }
 
     public function testWillFailWhenStreamIdsAreNotCorrect(): void
@@ -178,6 +178,48 @@ public function testValidResolutions($resolution, $isValid): void
         Validators::validateResolution($resolution);
     }
 
+    public function testValidLayoutClassListItem(): void
+    {
+        $layoutClassList = [
+            'id' => 'example_id',
+            'layoutClassList' => ['class1', 'class2']
+        ];
+
+        $this->assertNull(Validators::validateLayoutClassListItem($layoutClassList));
+    }
+
+    public function testInvalidIdType(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $layoutClassList = [
+            'id' => 123,
+            'layoutClassList' => ['class1', 'class2']
+        ];
+
+        Validators::validateLayoutClassListItem($layoutClassList);
+    }
+
+    public function testMissingLayoutClassList(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $layoutClassList = [
+            'id' => 'example_id'
+        ];
+
+        Validators::validateLayoutClassListItem($layoutClassList);
+    }
+
+    public function testInvalidLayoutClassListType(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $layoutClassList = [
+            'id' => 'example_id',
+            'layoutClassList' => 'invalid_class'
+        ];
+
+        Validators::validateLayoutClassListItem($layoutClassList);
+    }
+
     public function resolutionProvider(): array
     {
         return [