Skip to content

Commit b4d1431

Browse files
Adding support for @KafkaListener instrumentation via upgrade to opentracing-contrib/java-kafka-client:0.1.15. (#306)
Fixes #295.
1 parent c179980 commit b4d1431

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

instrument-starters/opentracing-spring-cloud-kafka-starter/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,12 @@
6666
<optional>true</optional>
6767
</dependency>
6868

69+
<dependency>
70+
<groupId>org.springframework</groupId>
71+
<artifactId>spring-aspects</artifactId>
72+
<optional>true</optional>
73+
</dependency>
74+
6975
<dependency>
7076
<groupId>org.springframework.boot</groupId>
7177
<artifactId>spring-boot-starter-test</artifactId>

instrument-starters/opentracing-spring-cloud-kafka-starter/src/main/java/io/opentracing/contrib/spring/cloud/kafka/KafkaAutoConfiguration.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@
1515

1616
import io.opentracing.Tracer;
1717
import io.opentracing.contrib.kafka.spring.TracingConsumerFactory;
18+
import io.opentracing.contrib.kafka.spring.TracingKafkaAspect;
1819
import io.opentracing.contrib.kafka.spring.TracingProducerFactory;
1920
import io.opentracing.contrib.spring.tracer.configuration.TracerAutoConfiguration;
21+
import org.springframework.aop.framework.ProxyFactoryBean;
2022
import org.springframework.beans.BeansException;
2123
import org.springframework.beans.factory.config.BeanPostProcessor;
2224
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
@@ -70,4 +72,10 @@ public Object postProcessAfterInitialization(Object bean, String beanName) throw
7072
}
7173
};
7274
}
75+
76+
@Bean
77+
@ConditionalOnClass(ProxyFactoryBean.class)
78+
public TracingKafkaAspect tracingKafkaAspect(Tracer tracer) {
79+
return new TracingKafkaAspect(tracer);
80+
}
7381
}

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
<version.io.opentracing.contrib-opentracing-spring-mongo>0.1.5</version.io.opentracing.contrib-opentracing-spring-mongo>
8989
<version.io.github.openfeign-feign-okhttp>10.2.0</version.io.github.openfeign-feign-okhttp>
9090
<version.io.github.openfeign.opentracing>0.4.0</version.io.github.openfeign.opentracing>
91-
<version.io.opentracing.contrib-opentracing-kafka-spring>0.1.12</version.io.opentracing.contrib-opentracing-kafka-spring>
91+
<version.io.opentracing.contrib-opentracing-kafka-spring>0.1.15</version.io.opentracing.contrib-opentracing-kafka-spring>
9292
<!-- spring-boot-starter-parent is a module of spring-boot-dependencies
9393
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/spring-boot-starter-parent/pom.xml -->
9494
<version.org.springframework.boot>2.2.0.RELEASE</version.org.springframework.boot>

0 commit comments

Comments
 (0)