Skip to content

Transmodel does not keep information that a journey is an "ExtraJourney" #7382

@sigtot

Description

@sigtot

Expected behavior

When a journey is added through SIRI data (having <ExtraJourney>true</ExtraJourney>), the transmodel API should:

  1. Let tripAlteration take the enum value extraJourney.
  2. Retain RealtimeState of "Added"

Observed behavior

  1. tripAlteration is null
  2. RealtimeState changes to "Updated" if a later SIRI update changes this journey

Note: Whether 2 is viable to fix is debatable, as it's not possible from the latest SIRI data to distinguish whether the realtime update is the first addition or a later update to an existing journey. Therefore, an OTP instance my change the value of RealtimeState when restarted, and if multiple instances are running in parallel, they may report different RealtimeState given the same query.

Version of OTP used (exact commit hash or JAR name)

dev-2.x

Steps to reproduce the problem

Entur reproduction link (valid 5. march)

Example query used for a valid extra journey:

{
  datedServiceJourney(id:"GOA:DatedServiceJourney:B709-7_20260305-AUD_AUD") {
    estimatedCalls {
      realtimeState
    }
    tripAlteration
  }
}

Result:

{
  "data": {
    "datedServiceJourney": {
      "estimatedCalls": [
        {
          "realtimeState": "Added"
        },
        {
          "realtimeState": "Added"
        },
        {
          "realtimeState": "Added"
        }
      ],
      "tripAlteration": null
    }
  }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions