Skip to content

Commit 97f8008

Browse files
author
valentin petrov
authored
V1.1.x CL/HIER: allreduce rab fix (#617)
* TL/UCP: scatter kn fix Don't check for INPLACE in current implementation of scatter knomial. It is used specifically for bcast_sag which has no notion of INPLACE. * CL/HIER: AVG not supported
1 parent a09d56e commit 97f8008

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/components/cl/hier/allreduce/allreduce_rab.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ UCC_CL_HIER_PROFILE_FUNC(ucc_status_t, ucc_cl_hier_allreduce_rab_init,
3939
ucc_base_coll_args_t args;
4040
int n_tasks, i;
4141

42+
if (coll_args->args.op == UCC_OP_AVG) {
43+
return UCC_ERR_NOT_SUPPORTED;
44+
}
4245
schedule = &ucc_cl_hier_get_schedule(cl_team)->super.super;
4346
if (ucc_unlikely(!schedule)) {
4447
return UCC_ERR_NO_MEMORY;
@@ -88,7 +91,7 @@ UCC_CL_HIER_PROFILE_FUNC(ucc_status_t, ucc_cl_hier_allreduce_rab_init,
8891
if (SBGP_ENABLED(cl_team, NODE) &&
8992
cl_team->top_sbgp != UCC_HIER_SBGP_NODE) {
9093
/* For bcast src should point to origin dst of allreduce */
91-
args.args.src.info = args.args.dst.info;
94+
args.args.src.info = args.args.dst.info;
9295
args.args.coll_type = UCC_COLL_TYPE_BCAST;
9396
status =
9497
ucc_coll_init(SCORE_MAP(cl_team, NODE), &args, &tasks[n_tasks]);

src/components/tl/ucp/scatter/scatter_knomial.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -219,11 +219,6 @@ ucc_status_t ucc_tl_ucp_scatter_knomial_init_r(
219219
ucc_rank_t rank = UCC_TL_TEAM_RANK(tl_team);
220220
ucc_tl_ucp_task_t *task;
221221

222-
/* In place currently not supported */
223-
if (UCC_IS_INPLACE(coll_args->args)) {
224-
return UCC_ERR_NOT_SUPPORTED;
225-
}
226-
227222
task = ucc_tl_ucp_init_task(coll_args, team);
228223
task->super.post = ucc_tl_ucp_scatter_knomial_start;
229224
task->super.progress = ucc_tl_ucp_scatter_knomial_progress;

0 commit comments

Comments
 (0)