UCS/NETLINK: code review fixes

Author: amastbaum

src/ucs/sys/netlink.c

@@ -309,9 +309,3 @@ int ucs_netlink_route_exists(int if_index, const struct sockaddr *sa_remote,
 
     return info.found;
 }
-
-int ucs_netlink_route_exists_allow_default(int if_index,
-                                           const struct sockaddr *sa_remote)
-{
-    return ucs_netlink_route_exists(if_index, sa_remote, 1);
-}

src/ucs/sys/netlink.h

@@ -60,21 +60,6 @@ ucs_netlink_send_request(int protocol, unsigned short nlmsg_type,
 int ucs_netlink_route_exists(int if_index, const struct sockaddr *sa_remote,
                              int allow_default_gw);
 
-/**
- * Check whether a routing table rule exists for a given network
- * interface name and a destination address, while allowing default gateway
- * routes.
- *
- * @param [in]  if_index   A global index representing the network interface,
-                           as assigned by the system (e.g., obtained via
-                           if_nametoindex()).
- * @param [in]  sa_remote  Pointer to the destination address.
- *
- * @return 1 if rule exists, or 0 otherwise.
- */
-int ucs_netlink_route_exists_allow_default(int if_index,
-                                           const struct sockaddr *sa_remote);
-
 END_C_DECLS
 
 #endif /* UCS_NETLINK_H */

src/uct/ib/base/ib_iface.c

@@ -710,7 +710,7 @@ uct_ib_iface_roce_is_routable(uct_ib_iface_t *iface, uint8_t gid_index,
         return 0;
     }
 
-    if (!ucs_netlink_route_exists_allow_default(ndev_index, sa_remote)) {
+    if (!ucs_netlink_route_exists(ndev_index, sa_remote, 1)) {
         /* try to use loopback interface for reachability check, because it may
          * be used for routing in case of an interface with VRF is configured
          * and a RoCE IP interface uses this VRF table for routing.
@@ -721,8 +721,7 @@ uct_ib_iface_roce_is_routable(uct_ib_iface_t *iface, uint8_t gid_index,
             return 0;
         }
 
-        if (!ucs_netlink_route_exists_allow_default(lo_ndev_index,
-                                                    sa_remote)) {
+        if (!ucs_netlink_route_exists(lo_ndev_index, sa_remote, 1)) {
             uct_iface_fill_info_str_buf(params,
                                         "remote address %s is not routable "
                                         "neither by interface "UCT_IB_IFACE_FMT