UCP/FT/RMA: get/offload/zcopy#11162
Merged
evgeny-leksikov merged 1 commit intoopenucx:masterfrom Feb 5, 2026
Merged
Conversation
evgeny-leksikov
changed the title
Contributor
|
/build |
evgeny-leksikov
force-pushed
the
ucp_ep_err_mode_failover_get
branch
3 times, most recently
from
d6ebf68 to
72be564
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds fault tolerance support for the GET RMA operation with the "offload/zcopy" protocol. It refactors the existing PUT fault tolerance tests to support both PUT and GET operations, and consolidates duplicate reset logic into a shared function.
Changes:
- Refactored fault tolerance test infrastructure to support both PUT and GET RMA operations
- Consolidated the
zcopy_resetimplementation into a shareducp_proto_offload_zcopy_resetfunction - Added new test cases for GET operations with initiator and target-side failures
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/gtest/ucp/test_ucp_fault_tolerance.cc | Refactored tests to support both PUT and GET operations with a unified test infrastructure |
| src/ucp/rma/put_offload.c | Removed duplicate reset function and switched to shared implementation |
| src/ucp/rma/get_offload.c | Updated to use shared reset function |
| src/ucp/proto/proto_common.h | Added declaration for shared reset function |
| src/ucp/proto/proto_common.c | Added shared reset function implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evgeny-leksikov
force-pushed
the
ucp_ep_err_mode_failover_get
branch
from
72be564 to
f80144d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gleon99
approved these changes
Feb 5, 2026
shasson5
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
FT support of "get/offload/zcopy" protocol
depends on #11155
Why?
Fault tolerance support