Open
Conversation
ofirfarjun7
reviewed
Apr 6, 2026
| %{_libdir}/pkgconfig/ucx-fuse.pc | ||
| %endif | ||
| %if %{with cuda} && %{with mlx5} | ||
| %{_libdir}/pkgconfig/ucx-ib-mlx5-gda.pc |
Contributor
There was a problem hiding this comment.
For future PR, do we need to move it under %files ib-mlx5-gda?
Contributor
There was a problem hiding this comment.
pkgconfig file for specific sub-module is needed only for static link (dynamic link uses only the top-level ucx.pc)
ofirfarjun7
approved these changes
Apr 6, 2026
yosefe
reviewed
Apr 11, 2026
Comment on lines
+36
to
+38
| # GDAKI files are packaged in ucx-cuda; the main ucx install's would claim | ||
| # them too. Install ucx first with those paths excluded, then install the | ||
| # remaining packages. |
Contributor
There was a problem hiding this comment.
can we exclude them by chaging usr/include/* in ucx.install to be more specific so that gda will not be included there?
|
|
||
| %files devel | ||
| %{_includedir}/uc* | ||
| %exclude %{_includedir}/uct/ib/mlx5/gdaki* |
Contributor
There was a problem hiding this comment.
%exclude %{_includedir}/uct/ib/mlx5/gdaki/*
| %{_libdir}/pkgconfig/ucx-fuse.pc | ||
| %endif | ||
| %if %{with cuda} && %{with mlx5} | ||
| %{_libdir}/pkgconfig/ucx-ib-mlx5-gda.pc |
Contributor
There was a problem hiding this comment.
pkgconfig file for specific sub-module is needed only for static link (dynamic link uses only the top-level ucx.pc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream of #11328