Skip to content

Commit c51dfb5

Browse files
committed
feat: cli requires node 14
1 parent d905839 commit c51dfb5

File tree

6 files changed

+4842
-6356
lines changed

6 files changed

+4842
-6356
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ jobs:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
10-
node-version: [12.x]
10+
node-version: [14.x]
1111
name: CI - node ${{ matrix.node-version }}
1212
steps:
13-
- uses: actions/checkout@v1
13+
- uses: actions/checkout@v3
1414
- name: set node.js ${{ matrix.node-version }}
15-
uses: actions/setup-node@v1
15+
uses: actions/setup-node@v3
1616
with:
1717
node-version: ${{ matrix.node-version }}
1818
- name: npm install
@@ -25,9 +25,9 @@ jobs:
2525
needs: test
2626
if: github.ref == 'refs/heads/master'
2727
steps:
28-
- uses: actions/checkout@v1
28+
- uses: actions/checkout@v3
2929
- name: Release
30-
uses: cycjimmy/semantic-release-action@v2
30+
uses: cycjimmy/semantic-release-action@v3
3131
with:
3232
extra_plugins: |
3333
@semantic-release/changelog

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v14

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ The command-line tool installs the 3rd-party registry as a scoped registry and m
3838
3939
## Installation
4040

41-
- Requires [nodejs 12](https://nodejs.org/en/download/).
41+
- Requires [nodejs 14 or above](https://nodejs.org/en/download/).
4242
- Install via npm:
4343

4444
```

lib/core.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const url = require("url");
66
const _ = require("lodash");
77
const chalk = require("chalk");
88
const mkdirp = require("mkdirp");
9-
const isIp = require("is-ip");
9+
const net = require('node:net');
1010
const isWsl = require("is-wsl");
1111
const keyFileStorage = require("key-file-storage").default;
1212
const TOML = require("@iarna/toml");
@@ -62,7 +62,7 @@ const parseEnv = async function(options, { checkPath }) {
6262
if (registry.endsWith("/")) registry = registry.slice(0, -1);
6363
env.registry = registry;
6464
const hostname = url.parse(registry).hostname;
65-
if (isIp(hostname)) env.namespace = hostname;
65+
if (net.isIP(hostname)) env.namespace = hostname;
6666
else
6767
env.namespace = hostname
6868
.split(".")

0 commit comments

Comments
 (0)