-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Labels
core libraryCore fVDB library. i.e. anything in the _Cpp module (C++) or fvdb python moduleCore fVDB library. i.e. anything in the _Cpp module (C++) or fvdb python modulegood first issueGood for newcomersGood for newcomersv0.1
Milestone
Description
📋 Originally created by @fwilliams
Original author: @fwilliams
Date: 2024-12-13T20:59:55Z
(Original issue by Jiahui Huang in the old repo)
When converting dense pytorch tensor from/to VDB jagged tensor, we need the min_ijk argument, whose default values are different in read_from_dense and read_into_dense -- this would cause confusion to users. Specifically:
- In
read_from_dense, its argumentdense_originsis by default [0,0,0]; - In
read_into_dense, its argumentmin_coordis by default 'null', which will be online computed asgrid.ijk.min().
We need to align those default values (maybe also align the naming of the arguments)
Also remember to change fvnn.VDBTensor's to_dense and from_dense interface accordingly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
core libraryCore fVDB library. i.e. anything in the _Cpp module (C++) or fvdb python moduleCore fVDB library. i.e. anything in the _Cpp module (C++) or fvdb python modulegood first issueGood for newcomersGood for newcomersv0.1
Type
Projects
Status
No status