Skip to content

Default values of min_ijk in read_from_dense and read_into_dense are different #122

@swahtz

Description

@swahtz

📋 Originally created by @fwilliams

Original author: @fwilliams
Date: 2024-12-13T20:59:55Z


(Original issue by Jiahui Huang in the old repo)

When converting dense pytorch tensor from/to VDB jagged tensor, we need the min_ijk argument, whose default values are different in read_from_dense and read_into_dense -- this would cause confusion to users. Specifically:

  • In read_from_dense, its argument dense_origins is by default [0,0,0];
  • In read_into_dense, its argument min_coord is by default 'null', which will be online computed as grid.ijk.min().

We need to align those default values (maybe also align the naming of the arguments)

Also remember to change fvnn.VDBTensor's to_dense and from_dense interface accordingly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    core libraryCore fVDB library. i.e. anything in the _Cpp module (C++) or fvdb python modulegood first issueGood for newcomersv0.1

    Type

    No type

    Projects

    Status

    No status

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions