Skip to content

Commit 0546b1d

Browse files
committed
Revert "Disable WSAs on more services (#34)"
This reverts commit ccabfc6.
1 parent c8a3935 commit 0546b1d

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

onvif/client.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -410,11 +410,10 @@ async def setup(self) -> ONVIFService:
410410
#
411411
# If this fails this is OK as it just means we will switch
412412
# to webhook later when the first notification is received.
413-
#
414-
# WSAs not enabled on this service per
415-
# https://github.com/home-assistant/core/issues/92308
413+
# WSAs enabled per
414+
# https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
416415
service = await self._device.create_onvif_service(
417-
"pullpoint", port_type="NotificationConsumer"
416+
"pullpoint", port_type="NotificationConsumer", enable_wsa=True
418417
)
419418
self._operation = service.document.bindings[service.binding_name].get(
420419
"PullMessages"
@@ -728,10 +727,10 @@ async def create_deviceio_service(self) -> ONVIFService:
728727
async def create_events_service(self) -> ONVIFService:
729728
"""Service creation helper.
730729
731-
WSAs not enabled on this service per
732-
https://github.com/home-assistant/core/issues/92308
730+
WSAs enabled per
731+
https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
733732
"""
734-
return await self.create_onvif_service("events")
733+
return await self.create_onvif_service("events", enable_wsa=True)
735734

736735
async def create_analytics_service(self) -> ONVIFService:
737736
"""Service creation helper."""
@@ -752,23 +751,24 @@ async def create_replay_service(self) -> ONVIFService:
752751
async def create_pullpoint_service(self) -> ONVIFService:
753752
"""Service creation helper.
754753
755-
WSAs not enabled on this service per
756-
https://github.com/home-assistant/core/issues/92308
754+
WSAs enabled per
755+
https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
757756
"""
758757
return await self.create_onvif_service(
759758
"pullpoint",
760759
port_type="PullPointSubscription",
761760
read_timeout=_PULLPOINT_TIMEOUT,
762761
write_timeout=_PULLPOINT_TIMEOUT,
762+
enable_wsa=True,
763763
)
764764

765765
async def create_notification_service(self) -> ONVIFService:
766766
"""Service creation helper.
767767
768-
WSAs not enabled on this service per
769-
https://github.com/home-assistant/core/issues/92308
768+
WSAs enabled per
769+
https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
770770
"""
771-
return await self.create_onvif_service("notification")
771+
return await self.create_onvif_service("notification", enable_wsa=True)
772772

773773
async def create_subscription_service(
774774
self, port_type: Optional[str] = None

0 commit comments

Comments
 (0)