Add support for more timestamp formats (#43)

Author: bdraco

onvif/client.py

@@ -3,7 +3,6 @@
 
 import asyncio
 import datetime as dt
-from functools import lru_cache
 import logging
 import os.path
 from typing import Any, Callable

onvif/types.py

@@ -2,7 +2,6 @@
 
 
 import ciso8601
-import isodate
 from zeep.xsd.types.builtins import DateTime, treat_whitespace
 
 
@@ -13,17 +12,14 @@ class FastDateTime(DateTime):
     @treat_whitespace("collapse")
     def pythonvalue(self, value):
         """Convert the xml value into a python value."""
+        if len(value) > 10 and value[10] == "-":  # 2010-01-01-00:00:00...
+            value[10] = "T"
+        if len(value) > 10 and value[11] == "-":  # 2023-05-15T-07:10:32Z...
+            value = value[:11] + value[12:]
+
         try:
             return ciso8601.parse_datetime(value)
         except ValueError:
             pass
-        # Determine based on the length of the value if it only contains a date
-        # lazy hack ;-)
 
-        if len(value) == 10:
-            value += "T00:00:00"
-        elif (len(value) == 19 or len(value) == 26) and value[10] == " ":
-            value = "T".join(value.split(" "))
-        elif len(value) > 10 and value[10] == "-":  # 2010-01-01-00:00:00...
-            value[10] = "T"
-        return isodate.parse_datetime(value)
+        return super().pythonvalue(value)

setup.py

@@ -10,8 +10,7 @@
 requires = [
     "httpx>=0.19.0,<1.0.0",
     "zeep[async]>=4.2.1,<5.0.0",
-    "ciso8601>=2.1.3",
-    "isodate>=0.6.0",
+    "ciso8601>=2.1.3"
 ]
 
 CLASSIFIERS = [