Skip to content

Commit c233aa3

Browse files
committed
remove unused code
1 parent 3343339 commit c233aa3

File tree

1 file changed

+17
-29
lines changed

1 file changed

+17
-29
lines changed

tests/test_zeep_transport.py

Lines changed: 17 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -126,39 +126,33 @@ async def test_get_returns_requests_response():
126126

127127
@pytest.mark.asyncio
128128
async def test_context_manager():
129-
"""Test async context manager creates and closes session."""
129+
"""Test async context manager doesn't close provided session."""
130130
mock_session = create_mock_session()
131131
transport = AIOHTTPTransport(session=mock_session)
132132

133-
# Initial session should be None (not the parent's requests session)
134-
assert transport.session is None or not isinstance(
135-
transport.session, aiohttp.ClientSession
136-
)
133+
# Session should already be set
134+
assert transport.session == mock_session
137135

138136
async with transport:
139-
assert transport.session is not None
140-
assert isinstance(transport.session, aiohttp.ClientSession)
137+
assert transport.session == mock_session
141138

142-
# Session should be closed after context
143-
assert transport.session is None
139+
# Session should still be there after context (not closed)
140+
assert transport.session == mock_session
144141

145142

146143
@pytest.mark.asyncio
147144
async def test_aclose():
148-
"""Test aclose() method closes the session."""
149-
mock_session = create_mock_session()
150-
transport = AIOHTTPTransport(session=mock_session)
151-
152-
# Create a mock session
145+
"""Test aclose() method doesn't close provided session."""
153146
mock_session = Mock(spec=aiohttp.ClientSession)
147+
mock_session.timeout = Mock(total=300, sock_read=None)
154148
mock_session.close = AsyncMock()
155-
transport.session = mock_session
149+
transport = AIOHTTPTransport(session=mock_session)
156150

157151
# Call aclose
158152
await transport.aclose()
159153

160-
# Verify session.close() was called
161-
mock_session.close.assert_called_once()
154+
# Verify session.close() was NOT called (we don't close provided sessions)
155+
mock_session.close.assert_not_called()
162156

163157

164158
def test_load_sync():
@@ -380,28 +374,22 @@ async def test_proxy_parameter():
380374

381375
@pytest.mark.asyncio
382376
async def test_verify_ssl_false():
383-
"""Test verify_ssl=False disables SSL verification."""
377+
"""Test verify_ssl=False is stored correctly."""
384378
mock_session = create_mock_session()
385379
transport = AIOHTTPTransport(session=mock_session, verify_ssl=False)
386380

387-
async with transport:
388-
# Check that SSL verification is disabled
389-
connector = transport.session.connector
390-
assert isinstance(connector, aiohttp.TCPConnector)
391-
assert connector._ssl is False
381+
# verify_ssl should be stored
382+
assert transport.verify_ssl is False
392383

393384

394385
@pytest.mark.asyncio
395386
async def test_verify_ssl_true():
396-
"""Test verify_ssl=True enables SSL verification."""
387+
"""Test verify_ssl=True is stored correctly."""
397388
mock_session = create_mock_session()
398389
transport = AIOHTTPTransport(session=mock_session, verify_ssl=True)
399390

400-
async with transport:
401-
# Check that SSL verification is enabled
402-
connector = transport.session.connector
403-
assert isinstance(connector, aiohttp.TCPConnector)
404-
assert connector._ssl is True
391+
# verify_ssl should be stored
392+
assert transport.verify_ssl is True
405393

406394

407395
@pytest.mark.asyncio

0 commit comments

Comments
 (0)