Skip to content

Commit ccabfc6

Browse files
authored
Disable WSAs on more services (#34)
1 parent 4318d80 commit ccabfc6

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

onvif/client.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -410,10 +410,11 @@ async def setup(self) -> ONVIFService:
410410
#
411411
# If this fails this is OK as it just means we will switch
412412
# to webhook later when the first notification is received.
413-
# WSAs enabled per
414-
# https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
413+
#
414+
# WSAs not enabled on this service per
415+
# https://github.com/home-assistant/core/issues/92308
415416
service = await self._device.create_onvif_service(
416-
"pullpoint", port_type="NotificationConsumer", enable_wsa=True
417+
"pullpoint", port_type="NotificationConsumer"
417418
)
418419
self._operation = service.document.bindings[service.binding_name].get(
419420
"PullMessages"
@@ -727,10 +728,10 @@ async def create_deviceio_service(self) -> ONVIFService:
727728
async def create_events_service(self) -> ONVIFService:
728729
"""Service creation helper.
729730
730-
WSAs enabled per
731-
https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
731+
WSAs not enabled on this service per
732+
https://github.com/home-assistant/core/issues/92308
732733
"""
733-
return await self.create_onvif_service("events", enable_wsa=True)
734+
return await self.create_onvif_service("events")
734735

735736
async def create_analytics_service(self) -> ONVIFService:
736737
"""Service creation helper."""
@@ -751,24 +752,23 @@ async def create_replay_service(self) -> ONVIFService:
751752
async def create_pullpoint_service(self) -> ONVIFService:
752753
"""Service creation helper.
753754
754-
WSAs enabled per
755-
https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
755+
WSAs not enabled on this service per
756+
https://github.com/home-assistant/core/issues/92308
756757
"""
757758
return await self.create_onvif_service(
758759
"pullpoint",
759760
port_type="PullPointSubscription",
760761
read_timeout=_PULLPOINT_TIMEOUT,
761762
write_timeout=_PULLPOINT_TIMEOUT,
762-
enable_wsa=True,
763763
)
764764

765765
async def create_notification_service(self) -> ONVIFService:
766766
"""Service creation helper.
767767
768-
WSAs enabled per
769-
https://github.com/home-assistant/core/issues/83524 https://github.com/home-assistant/core/issues/45513
768+
WSAs not enabled on this service per
769+
https://github.com/home-assistant/core/issues/92308
770770
"""
771-
return await self.create_onvif_service("notification", enable_wsa=True)
771+
return await self.create_onvif_service("notification")
772772

773773
async def create_subscription_service(
774774
self, port_type: Optional[str] = None

0 commit comments

Comments
 (0)