Add common valve function for TRV and FHT channel (#623)

* add isValveOpen

* add test cases

Author: CFenner

PyViCare/PyViCareFloorHeating.py

@@ -30,3 +30,7 @@ def setName(self, name: str) -> None:
     @handleNotSupported
     def getValveState(self) -> str:
         return str(self.service.getProperty("fht.valve.state")["properties"]["status"]["value"])
+
+    @handleNotSupported
+    def isValveOpen(self) -> bool:
+        return bool(self.getValveState() != "closed")

PyViCare/PyViCareRadiatorActuator.py

@@ -12,6 +12,10 @@ def getTemperature(self):
     def getValvePosition(self) -> int:
         return int(self.service.getProperty("trv.valve.position")["properties"]["position"]["value"])
 
+    @handleNotSupported
+    def isValveOpen(self) -> bool:
+        return bool(self.getValvePosition() > 0)
+
     @handleNotSupported
     def getChildLock(self) -> str:
         return str(self.service.getProperty("trv.childLock")["properties"]["status"]["value"])

tests/test_zigbee_zk03838_fht.py

@@ -49,3 +49,6 @@ def test_getName(self):
     def test_getValveState(self):
         self.assertEqual(
             self.device.getValveState(), "closed")
+
+    def test_isValveOpen(self):
+        self.assertFalse(self.device.isValveOpen())

tests/test_zigbee_zk03840_trv.py

@@ -35,3 +35,6 @@ def test_setTargetTemperature(self):
         self.assertEqual(self.service.setPropertyData[0]['property_name'], 'trv.temperature')
         self.assertEqual(self.service.setPropertyData[0]['action'], 'setTargetTemperature')
         self.assertEqual(self.service.setPropertyData[0]['data'], {'temperature': 22})
+
+    def test_isValveOpen(self):
+        self.assertTrue(self.device.isValveOpen())