Skip to content

Commit 9622821

Browse files
authored
feat: gateway wifi datapoint (#694)
* expose wifi * add test case * remove missing property test * update test case * add typing
1 parent ece5683 commit 9622821

File tree

8 files changed

+22
-3
lines changed

8 files changed

+22
-3
lines changed

PyViCare/PyViCareGateway.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ def getSerial(self):
99
return self.getProperty("gateway.devices")["gatewayId"]
1010

1111
@handleNotSupported
12-
def getWifiSignalStrength(self):
13-
return self.getProperty("gateway.wifi")["properties"]["strength"]["value"]
12+
def getWifiSignalStrength(self) -> int:
13+
return int(self.getProperty("gateway.wifi")["properties"]["strength"]["value"])

PyViCare/PyViCareHeatingDevice.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ class HeatingDevice(Device):
3636
Note that currently, a new token is generated for each run.
3737
"""
3838

39+
@handleNotSupported
40+
def getWifiSignalStrength(self) -> int:
41+
return int(self.getProperty("tcu.wifi")["properties"]["strength"]["value"])
42+
3943
@property
4044
def circuits(self) -> List[Any]:
4145
return list([self.getCircuit(x) for x in self.getAvailableCircuits()])

PyViCare/PyViCareVentilationDevice.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ class VentilationDevice(Device):
1212
Note that currently, a new token is generated for each run.
1313
"""
1414

15+
@handleNotSupported
16+
def getWifiSignalStrength(self) -> int:
17+
return int(self.getProperty("tcu.wifi")["properties"]["strength"]["value"])
18+
1519
@handleNotSupported
1620
def getVentilationDemand(self) -> str:
1721
return str(self.getProperty("ventilation.operating.state")["properties"]["demand"]["value"])

tests/test_TestForMissingProperties.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ def test_missingProperties(self):
105105
'heating.secondaryCircuit.valves.fourThreeWay',
106106
'heating.secondaryHeatGenerator',
107107
'heating.valves.fourThreeWay.position',
108-
'tcu.wifi',
109108

110109
'heating.boiler.pumps.internal',
111110
'heating.boiler.pumps.internal.target',

tests/test_Vitocal250A.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,3 +241,6 @@ def test_inverter_getPower(self):
241241

242242
def test_inverter_getTemperature(self):
243243
self.assertEqual(self.device.inverters[0].getTemperature(), 26.3)
244+
245+
def test_getWifiSignalStrength(self):
246+
self.assertEqual(self.device.getWifiSignalStrength(), -30)

tests/test_Vitodens100W.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,6 @@ def test_getPowerSummaryConsumptionDomesticHotWaterCurrentYear(self):
3939

4040
def test_getGasSummaryConsumptionDomesticHotWaterUnit(self):
4141
self.assertEqual(self.device.getGasSummaryConsumptionDomesticHotWaterUnit(), "cubicMeter")
42+
43+
def test_getWifiSignalStrength(self):
44+
self.assertEqual(self.device.getWifiSignalStrength(), -65)

tests/test_Vitopure350.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,3 +93,6 @@ def test_getAirborneDust(self):
9393
self.assertEqual(self.device.getAirborneDustPM2d5(), 0.3)
9494
self.assertEqual(self.device.getAirborneDustPM4(), 0.4)
9595
self.assertEqual(self.device.getAirborneDustPM10(), 0.5)
96+
97+
def test_getWifiSignalStrength(self):
98+
self.assertEqual(self.device.getWifiSignalStrength(), -41)

tests/test_VitovalorPT2.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,3 +202,6 @@ def test_getFuelCellGasConsumptionThisYear(self):
202202
def test_getSupplyPressure(self):
203203
self.assertEqual(self.device.getSupplyPressure(), 1.7)
204204
self.assertEqual(self.device.getSupplyPressureUnit(), "bar")
205+
206+
def test_getWifiSignalStrength(self):
207+
self.assertEqual(self.device.getWifiSignalStrength(), -47)

0 commit comments

Comments
 (0)