Skip to content

Commit e8b740c

Browse files
authored
chore(testdata): add Vitocal 222S sample data (#646)
* add testdata for vitocal222s * update missing properties
1 parent d3b58bd commit e8b740c

10 files changed

+8700
-2454
lines changed
File renamed without changes.

tests/response/Vitocal222S-with-Vitovent.json

Lines changed: 4216 additions & 0 deletions
Large diffs are not rendered by default.

tests/response/Vitocal222S.json

Lines changed: 4440 additions & 2398 deletions
Large diffs are not rendered by default.
File renamed without changes.

tests/test_TestForMissingProperties.py

Lines changed: 22 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ def test_missingProperties(self):
2828
'device.productIdentification',
2929
'device.productMatrix',
3030
'device.time.daylightSaving',
31-
'device.identification',
32-
'device.zigbee.parent.rx',
33-
'device.zigbee.parent.tx',
3431
'device.heatingCircuitId',
3532
'device.configuration.houseLocation',
3633
'device.lock.malfunction',
@@ -41,15 +38,6 @@ def test_missingProperties(self):
4138
'device.timeseries.water.pressure.peaks',
4239
'device.information',
4340
'device.configuration.measurementWeight',
44-
'device.configuration.houseLocation',
45-
'device.lock.malfunction',
46-
'device.timeseries.burner.stops',
47-
'device.timeseries.dhw.burner.stops',
48-
'device.timeseries.ignitionTimeSteps',
49-
'device.timeseries.monitoringIonization',
50-
'device.timeseries.water.pressure.peaks',
51-
'device.zigbee.active',
52-
'device.zigbee.status',
5341
'device.actorSensorTest',
5442
'device.brand',
5543
'device.lock.external',
@@ -105,7 +93,6 @@ def test_missingProperties(self):
10593
'heating.configuration.centralHeatingCylinderSize',
10694
'heating.configuration.dhwCylinderPump',
10795
'heating.configuration.dhwCylinderSize',
108-
'device.messages.info.raw',
10996
'heating.configuration.gasType',
11097
'heating.configuration.houseHeatingLoad',
11198
'heating.configuration.houseLocation',
@@ -116,7 +103,7 @@ def test_missingProperties(self):
116103
'heating.heat.production.summary.dhw',
117104
'heating.heat.production.summary.heating',
118105

119-
# heating ignored for now
106+
# heating - not yet used
120107
'heating.operating.programs.holidayAtHome',
121108
'heating.operating.programs.holiday',
122109
'heating.device.time.offset',
@@ -125,34 +112,27 @@ def test_missingProperties(self):
125112
'heating.boiler.airflaps.1.position.current',
126113
'heating.boiler.pumps.internal',
127114
'heating.boiler.pumps.internal.target',
128-
129115
'heating.circuits.0.dhw.pumps.circulation.schedule',
130116
'heating.circuits.0.dhw.schedule',
131117
'heating.power.consumption.dhw',
132118
'heating.power.consumption',
133-
134119
'heating.circuits.0.temperature.levels', # hint: command
135120
'heating.dhw.hygiene',
136121
'heating.dhw.temperature',
137122
'heating.burners',
138-
123+
'heating.sensors.temperature.allengra',
139124
'heating.dhw.hygiene.trigger',
140-
'heating.dhw.operating.modes.off',
141125
'heating.dhw.temperature.hygiene',
142-
'heating.sensors.temperature.allengra',
143-
126+
'heating.dhw.operating.modes.off',
144127
'heating.dhw.operating.modes.active',
145128
'heating.dhw.operating.modes.comfort',
146129
'heating.dhw.operating.modes.eco',
147-
148130
'heating.circuits.0.heating.roomInfluenceFactor',
149131
'heating.circuits.0.temperature', # TODO: to analyse, from Vitodens 100W
150132
'heating.circuits.0.operating.programs.noDemand.hmiState', # TODO: to analyse, from Vitodens 100W
151133
'heating.circuits.0.name', # TODO: to analyse, from Vitodens 100W
152134
'heating.circuits.0.zone.mode', # TODO: to analyse, from Vitocal 250A
153-
154135
'heating.configuration.dhw.temperature.dhwCylinder.max', # TODO: to analyse, from Vitocal 333G
155-
156136
'heating.buffer.sensors.temperature.main', # deprecated, removed 2024-09-15 FIXME: remove once data point is removed and test data is updated
157137
'heating.buffer.sensors.temperature.top', # deprecated, removed 2024-09-15 FIXME: remove once data point is removed and test data is updated
158138
'heating.dhw.sensors.temperature.hotWaterStorage', # deprecated, removed 2024-09-15 FIXME: remove once data point is removed and test data is updated
@@ -166,7 +146,16 @@ def test_missingProperties(self):
166146

167147
# gateway
168148

149+
# zigbee
150+
'device.zigbee.lqi',
151+
'device.zigbee.parent.rx',
152+
'device.zigbee.parent.tx',
153+
'device.zigbee.active',
154+
'device.zigbee.status',
155+
169156
# heat pump
157+
'heating.circuits.0.cooling.hysteresis.switch',
158+
'heating.circuits.0.heating.hysteresis.switch',
170159
'heating.circuits.0.operating.programs.screedDrying.heatpump',
171160
'heating.compressors.0.heat.production.cooling.week',
172161
'heating.compressors.0.heat.production.dhw.week',
@@ -198,6 +187,13 @@ def test_missingProperties(self):
198187
'heating.sensors.temperature.hotGas',
199188
'heating.sensors.temperature.liquidGas',
200189
'heating.sensors.temperature.suctionGas',
190+
'heating.heatingRod.power.consumption.summary.dhw',
191+
'heating.heatingRod.power.consumption.summary.heating',
192+
'heating.heatingRod.status',
193+
'heating.scop.dhw', # deprecated
194+
'heating.scop.heating', # deprecated
195+
'heating.scop.total', # deprecated
196+
'heating.dhw.comfort', # deprecated
201197

202198
# ventilation - not yet used
203199
'ventilation.control.filterChange',
@@ -218,14 +214,6 @@ def test_missingProperties(self):
218214
'ventilation.quickmodes.comfort',
219215
'ventilation.quickmodes.eco',
220216
'ventilation.quickmodes.holiday',
221-
'heating.heatingRod.power.consumption.summary.dhw',
222-
'heating.heatingRod.power.consumption.summary.heating',
223-
'heating.heatingRod.status',
224-
'heating.power.consumption.current',
225-
'heating.scop.dhw', # deprecated
226-
'heating.scop.heating', # deprecated
227-
'heating.scop.total', # deprecated
228-
'heating.dhw.comfort', # deprecated
229217

230218
# energy system - not yet used
231219
'device.etn',
@@ -245,18 +233,13 @@ def test_missingProperties(self):
245233
'photovoltaic.string.current',
246234
'photovoltaic.string.voltage',
247235

248-
# TRVs
249-
'device.zigbee.lqi',
250-
'device.zigbee.parent.id',
251-
'trv.childLock',
252-
'trv.mountingMode',
253-
'trv.valve.position',
254-
255-
# FHT
236+
# FHT - not yet used
256237
'fht.configuration.floorCoolingCondensationShutdownMargin',
257238
'fht.configuration.floorCoolingCondensationThreshold',
258239
'fht.configuration.floorHeatingDamageProtectionThreshold',
259240
'fht.valve',
241+
242+
# DEPRECATED
260243
]
261244

262245
all_features = self.read_all_features()

tests/test_vitocal-with-vitovent.py renamed to tests/test_Vitocal200S_with_Vitovent300W.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
from tests.ViCareServiceMock import ViCareServiceMock
55

66

7-
class Vitocal_200S_with_Vitovent_300W(unittest.TestCase):
7+
class Vitocal200S_with_Vitovent300W(unittest.TestCase):
88
def setUp(self):
9-
self.service = ViCareServiceMock('response/Vitocal-200S-with-Vitovent-300W.json')
9+
self.service = ViCareServiceMock('response/Vitocal200S-with-Vitovent300W.json')
1010
self.device = HeatPump(self.service)
1111

1212
def test_isDomesticHotWaterDevice(self):
@@ -44,15 +44,3 @@ def test_ventilationQuickmodes(self):
4444
"eco",
4545
"holiday",
4646
])
47-
48-
class Vitocal_333G_with_Vitovent_300F(unittest.TestCase):
49-
def setUp(self):
50-
self.service = ViCareServiceMock('response/Vitocal-333G-with-Vitovent-300F.json')
51-
self.device = HeatPump(self.service)
52-
53-
def test_getHeatExchangerFrostProtectionActive(self):
54-
self.assertFalse(self.device.getHeatExchangerFrostProtectionActive())
55-
56-
def test_getVolumeFlow(self):
57-
self.assertEqual(self.device.getSupplyVolumeFlow(), 257)
58-
self.assertEqual(self.device.getExhaustVolumeFlow(), 257)
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
from tests.ViCareServiceMock import ViCareServiceMock
77

88

9-
class Vitocal222S(unittest.TestCase):
9+
class Vitocal222S_with_Vitovent(unittest.TestCase):
1010
def setUp(self):
11-
self.service = ViCareServiceMock('response/Vitocal222S.json')
11+
self.service = ViCareServiceMock('response/Vitocal222S-with-Vitovent.json')
1212
self.device = HeatPump(self.service)
1313

1414
def test_getDomesticHotWaterActiveMode_10_10_time(self):
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import unittest
2+
3+
from PyViCare.PyViCareHeatPump import HeatPump
4+
from tests.ViCareServiceMock import ViCareServiceMock
5+
6+
7+
class Vitocal333G_with_Vitovent300F(unittest.TestCase):
8+
def setUp(self):
9+
self.service = ViCareServiceMock('response/Vitocal333G-with-Vitovent300F.json')
10+
self.device = HeatPump(self.service)
11+
12+
def test_getHeatExchangerFrostProtectionActive(self):
13+
self.assertFalse(self.device.getHeatExchangerFrostProtectionActive())
14+
15+
def test_getVolumeFlow(self):
16+
self.assertEqual(self.device.getSupplyVolumeFlow(), 257)
17+
self.assertEqual(self.device.getExhaustVolumeFlow(), 257)

tests/test_VitochargeVX3.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
class VitochargeVX3(unittest.TestCase):
88
def setUp(self):
9-
self.service = ViCareServiceMock('response/VitochargeVX3.json')
9+
self.service = ViCareServiceMock('response/Vitocharge03.json')
1010
self.device = ElectricalEnergySystem(self.service)
1111

1212
def test_isDomesticHotWaterDevice(self):

0 commit comments

Comments
 (0)