- AEM: variables as constants.

Author: alegauss

turing-aem/aem-commons/src/main/java/com/viglet/turing/connector/aem/commons/config/IAemConfiguration.java

@@ -21,7 +21,6 @@
 import com.viglet.turing.connector.aem.commons.context.TurAemLocalePathContext;
 
 import java.net.URI;
-import java.net.URL;
 import java.util.Collection;
 import java.util.Locale;
 

turing-aem/aem-plugin/src/main/java/com/viglet/turing/connector/plugin/aem/TurAemPluginProcess.java

@@ -84,10 +84,10 @@ public class TurAemPluginProcess {
     private IAemConfiguration config = null;
     private TurAemContentDefinitionProcess turAemContentDefinitionProcess;
     // Legacy
-    private static final boolean reindex = false;
-    private static final boolean reindexOnce = false;
-    private static final boolean dryRun = false;
-    private static final boolean delivered = false;
+    private static final boolean REINDEX = false;
+    private static final boolean REINDEX_ONCE = false;
+    private static final boolean DRY_RUN = false;
+    private static final boolean DELIVERED = false;
 
     @Inject
     public TurAemPluginProcess(TurAemPluginIndexingRepository turAemPluginIndexingRepository,
@@ -117,14 +117,14 @@ public void run(TurAemSource turAemSource, TurConnectorContext turConnectorConte
         turAemContentDefinitionProcess = new TurAemContentDefinitionProcess(getTurAemContentMapping(turAemSource));
         TurAemSourceContext turAemSourceContext = getTurAemSourceContext(config);
         try {
-            if (reindex) {
+            if (REINDEX) {
                 turAemIndexingRepository.deleteContentsToReindex(turAemSourceContext.getId());
             }
-            if (reindexOnce) {
+            if (REINDEX_ONCE) {
                 turAemIndexingRepository.deleteContentsToReindexOnce(turAemSourceContext.getId());
             }
             this.getNodesFromJson(turAemSourceContext);
-            if (!dryRun) {
+            if (!DRY_RUN) {
                 deIndexObjects(turAemSourceContext);
                 updateSystemOnce(turAemSourceContext);
             }
@@ -334,15 +334,15 @@ private boolean ddlNeedBeReIndexed(TurAemObject aemObject, TurAemSourceContext t
     private void indexObject(@NotNull TurAemObject aemObject, TurAemModel turAemModel,
                              List<TurSNAttributeSpec> turSNAttributeSpecList,
                              TurAemSourceContext turAemSourceContext) {
-        if (!delivered || aemObject.isDelivered()) {
+        if (!DELIVERED || aemObject.isDelivered()) {
             final Locale locale = TurAemCommonsUtils.getLocaleFromAemObject(turAemSourceContext, aemObject);
             if (objectNeedBeIndexed(aemObject, turAemSourceContext)) {
                 sendIndex(aemObject, turAemModel, turSNAttributeSpecList, turAemSourceContext, locale);
             } else {
                 if (objectNeedBeReIndexed(aemObject, turAemSourceContext)) {
                     sendReindex(aemObject, turAemModel, turSNAttributeSpecList, turAemSourceContext, locale);
                 }
-                if (!dryRun) {
+                if (!DRY_RUN) {
                     updateIndexingStatus(aemObject, locale, turAemSourceContext);
                 }
             }
@@ -355,7 +355,7 @@ private void indexObject(@NotNull TurAemObject aemObject, TurAemModel turAemMode
     private void sendReindex(TurAemObject aemObject, TurAemModel turAemModel,
                              List<TurSNAttributeSpec> turSNAttributeSpecList,
                              TurAemSourceContext turAemSourceContext, Locale locale) {
-        if (!dryRun) {
+        if (!DRY_RUN) {
             turAemIndexingRepository.findByAemIdAndIndexGroup(aemObject.getPath(), turAemSourceContext.getId())
                     .ifPresent(turAemIndexingsList ->
                             log.info("ReIndexed {} object ({}) from {} to {} and deltaId = {}",
@@ -371,7 +371,7 @@ private void sendReindex(TurAemObject aemObject, TurAemModel turAemModel,
     private void sendIndex(TurAemObject aemObject, TurAemModel turAemModel,
                            List<TurSNAttributeSpec> turSNAttributeSpecList, TurAemSourceContext turAemSourceContext,
                            Locale locale) {
-        if (!dryRun) {
+        if (!DRY_RUN) {
             createIndexingStatus(aemObject, locale, turAemSourceContext);
         }
         sendToTuringToBeIndexed(aemObject, turAemModel, turSNAttributeSpecList, locale,