- Sprinklr Code Smells

Author: alegauss

pom.xml

@@ -189,6 +189,11 @@
                 <artifactId>turing-java-sdk</artifactId>
                 <version>${project.version}</version>
             </dependency>
+            <dependency>
+                <groupId>com.viglet.turing</groupId>
+                <artifactId>turing-commons</artifactId>
+                <version>${project.version}</version>
+            </dependency>
             <dependency>
                 <groupId>ch.qos.logback</groupId>
                 <artifactId>logback-classic</artifactId>

turing-sprinklr/pom.xml

@@ -12,9 +12,6 @@
     <version>${revision}</version>
     <name>Turing Sprinklr</name>
     <description>Turing Sprinklr Connector</description>
-    <modules>
-        <module>sprinklr-java-sdk</module>
-    </modules>
     <packaging>pom</packaging>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

turing-sprinklr/sprinklr-app/src/main/java/com/viglet/turing/connector/sprinklr/TurSprinklrApplication.java

@@ -2,8 +2,8 @@
 
 import com.fasterxml.jackson.databind.Module;
 import com.fasterxml.jackson.datatype.hibernate5.jakarta.Hibernate5JakartaModule;
-import com.viglet.turing.sprinklr.plugins.KeyValueTransformer;
-import com.viglet.turing.sprinklr.plugins.PluginContext;
+import com.viglet.turing.sprinklr.plugins.TurSprinklrKeyValueTransformer;
+import com.viglet.turing.sprinklr.plugins.TurSprinklrPluginContext;
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.boot.web.servlet.FilterRegistrationBean;
@@ -35,14 +35,14 @@ Module hibernate5Module() {
     }
 
     @Bean
-    public PluginContext pluginContext(KeyValueTransformer transformer) {
-        PluginContext pluginContext = new PluginContext();
+    public TurSprinklrPluginContext pluginContext(TurSprinklrKeyValueTransformer transformer) {
+        TurSprinklrPluginContext pluginContext = new TurSprinklrPluginContext();
         pluginContext.addPlugin(transformer);
         return pluginContext;
     }
 
     @Bean
-    public KeyValueTransformer keyValueTransformer() {
-        return new KeyValueTransformer();
+    public TurSprinklrKeyValueTransformer keyValueTransformer() {
+        return new TurSprinklrKeyValueTransformer();
     }
 }

turing-sprinklr/sprinklr-app/src/main/java/com/viglet/turing/connector/sprinklr/TurSprinklrProcess.java

@@ -17,8 +17,7 @@
 import com.viglet.turing.connector.sprinklr.persistence.model.TurSprinklrAttributeMapping;
 import com.viglet.turing.connector.sprinklr.persistence.model.TurSprinklrSource;
 import com.viglet.turing.connector.sprinklr.persistence.repository.TurSprinklrAttributeMappingRepository;
-import com.viglet.turing.sprinklr.plugins.KeyValueTransformer;
-import com.viglet.turing.sprinklr.plugins.PluginContext;
+import com.viglet.turing.sprinklr.plugins.TurSprinklrPluginContext;
 import com.viglet.turing.connector.sprinklr.utils.FileAsset;
 import com.viglet.turing.connector.sprinklr.utils.FileAssetsExtractor;
 import com.viglet.turing.sprinklr.client.service.kb.TurSprinklrKBService;
@@ -49,14 +48,14 @@ public class TurSprinklrProcess {
      */
     private TurSNJobItems turSNJobItems = new TurSNJobItems();
 
-    private PluginContext pluginContext;
+    private TurSprinklrPluginContext pluginContext;
 
     @Inject
     public TurSprinklrProcess(@Value("${turing.url}") String turingUrl,
                               @Value("${turing.apiKey}") String turingApiKey,
                               @Value("${turing.sprinklr.job.size}") int jobSize,
                               TurSprinklrAttributeMappingRepository turSprinklrAttributeMappingRepository,
-                              PluginContext pluginContext
+                              TurSprinklrPluginContext pluginContext
                               ) {
         this.turingUrl = turingUrl;
         this.turingApiKey = turingApiKey;

turing-sprinklr/sprinklr-app/src/test/java/com/viglet/turing/connector/sprinklr/plugins/PluginContextTest.java

@@ -1,6 +1,6 @@
 package com.viglet.turing.connector.sprinklr.plugins;
 
-import com.viglet.turing.sprinklr.plugins.KeyValueTransformer;
+import com.viglet.turing.sprinklr.plugins.TurSprinklrKeyValueTransformer;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
@@ -10,78 +10,72 @@
 import static org.junit.jupiter.api.Assertions.*;
 
 @SpringBootTest
-class KeyValueTransformerTest {
+class TurSprinklrKeyValueTransformerTest {
 
     @Autowired
-    private KeyValueTransformer transformer;
+    private TurSprinklrKeyValueTransformer transformer;
 
     @Test
     void loadMapping() {
-        // Caminho para o arquivo de teste (ajustar para o local correto)
+        // Path to test file (adjust to correct location)
         String testFile = "src/test/resources/test-mapping.txt";
 
-        // Chama o método loadMapping
+        // Call the loadMapping method
         transformer.loadMapping(testFile);
 
-        // Verifica se o mapeamento foi carregado
+        // Checks if the mapping has been loaded
         Map<String, String> mapping = transformer.getMapping(testFile);
         assertNotNull(mapping, "Mapping should not be null after loading");
         assertFalse(mapping.isEmpty(), "Mapping should not be empty after loading");
 
-        // Verifica se uma chave específica foi carregada corretamente
-        assertEquals("ação", mapping.get("424123421312"), "Value for key '424123421312' should be 'ação'");
+        // Checks if a specific key was loaded correctly
+        assertEquals("action", mapping.get("424123421312"), "Value for key '424123421312' should be 'ação'");
     }
 
     @Test
     void getMapping() {
-        // Caminho para o arquivo de teste (ajustar para o local correto)
+        // Path to test file (adjust to correct location)
         String testFile = "src/test/resources/test-mapping.txt";
 
-        // Certifique-se de que o mapeamento foi carregado
+        // Make sure the mapping has been loaded
         transformer.loadMapping(testFile);
 
-        // Recupera o mapeamento e verifica
+        // Retrieves the mapping and checks
         Map<String, String> mapping = transformer.getMapping(testFile);
         assertNotNull(mapping, "Mapping should not be null");
-        // Há duas linhas com a mesma chave
+        // There are two lines with the same key
         assertEquals(2, mapping.size(), "Mapping should have 2 entries");
 
-        // Verifica se uma chave específica está presente
+        // Checks if a specific key is present
         assertTrue(mapping.containsKey("235521957944"), "Mapping should contain key '235521957944'");
     }
 
     @Test
     void transform() {
-        // Caminho para o arquivo de teste (ajustar para o local correto)
+        // Path to test file (adjust to correct location)
         String testFile = "src/test/resources/test-mapping.txt";
 
-        // Certifique-se de que o mapeamento foi carregado
+        // Make sure the mapping has been loaded
         transformer.loadMapping(testFile);
 
-        // Testa a transformação
+        // Test the transformation
         String transformedValue = transformer.transform("424123421312", testFile);
-        assertEquals("ação", transformedValue, "Transformed value should be 'ação'");
-
-        // Testa uma chave inexistente
-        String missingValue = transformer.transform("999999999999", testFile);
+        assertEquals("action", transformedValue, "Transformed value should be 'ação'");
     }
 
     @Test
-    void loadMappingTransfromLoadSameMapTransform(){
-        // Caminho para o arquivo de teste (ajustar para o local correto)
+    void loadMappingTransFromLoadSameMapTransform() {
+        // Path to test file (adjust to correct location)
         String testFile = "src/test/resources/test-mapping.txt";
 
-        // Chama o método loadMapping
+        // Call the loadMapping method
         transformer.loadMapping(testFile);
 
         var transformedValue = transformer.transform("424123421312", testFile);
-        assertEquals("ação", transformedValue, "Transformed value should be 'ação'");
+        assertEquals("action", transformedValue, "Transformed value should be 'ação'");
         transformer.loadMapping(testFile);
         transformedValue = transformer.transform("235521957944", testFile);
-        assertEquals("aventura", transformedValue, "Transformed value should be 'aventura'");
-
-
-
+        assertEquals("adventure", transformedValue, "Transformed value should be 'aventura'");
     }
 
     @Test

…klr/plugins/KeyValueTransformerTest.java …/TurSprinklrKeyValueTransformerTest.javaturing-sprinklr/sprinklr-app/src/test/java/com/viglet/turing/connector/sprinklr/plugins/KeyValueTransformerTest.java renamed to turing-sprinklr/sprinklr-app/src/test/java/com/viglet/turing/connector/sprinklr/plugins/TurSprinklrKeyValueTransformerTest.java turing-sprinklr/sprinklr-app/src/test/java/com/viglet/turing/connector/sprinklr/plugins/KeyValueTransformerTest.java renamed to turing-sprinklr/sprinklr-app/src/test/java/com/viglet/turing/connector/sprinklr/plugins/TurSprinklrKeyValueTransformerTest.java

@@ -0,0 +1,20 @@
+package com.viglet.turing.connector.sprinklr.plugins;
+
+import com.viglet.turing.sprinklr.plugins.TurSprinklrKeyValueTransformer;
+import com.viglet.turing.sprinklr.plugins.TurSprinklrPluginContext;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+
+@SpringBootTest ()
+class TurSprinklrPluginContextTest {
+
+    @Autowired
+    private TurSprinklrPluginContext pluginContext;
+
+    @Test
+    void testGetPlugin() {
+        pluginContext.getPlugin(TurSprinklrKeyValueTransformer.class);
+    }
+
+}

turing-sprinklr/sprinklr-app/src/test/java/com/viglet/turing/connector/sprinklr/plugins/TurSprinklrPluginContextTest.java

@@ -1,3 +1,3 @@
-424123421312 ação
-235521957944 aventura
-235521957944 comédia
+424123421312 action
+235521957944 adventure
+235521957944 comedy

turing-sprinklr/sprinklr-app/src/test/resources/test-mapping.txt

@@ -2,19 +2,18 @@
 
 import com.viglet.turing.sprinklr.client.service.kb.response.TurSprinklrSearchResult;
 import com.viglet.turing.sprinklr.client.service.token.TurSprinklrAccessToken;
-import com.viglet.turing.sprinklr.plugins.PluginContext;
+import com.viglet.turing.sprinklr.plugins.TurSprinklrPluginContext;
 import lombok.Builder;
 import lombok.Getter;
 import lombok.Setter;
 import lombok.ToString;
 
-// Classe repetida
 @Builder
 @Getter
 @Setter
 @ToString
 public class TurSprinklrContext {
     private TurSprinklrSearchResult searchResult;
     private TurSprinklrAccessToken accessToken;
-    private PluginContext pluginContext;
+    private TurSprinklrPluginContext pluginContext;
 }