Apply suggestions from code review

Co-authored-by: Alexander Dokuchaev <[email protected]>

Author: daniil-lyakhov

src/nncf/common/graph/graph.py

@@ -812,16 +812,16 @@ def find_matching_subgraphs(self, patterns: GraphPattern, strict: bool = True) -
         return output
 
 
-def get_ignored_names_by_ignored_patterns(nncf_graph: NNCFGraph, ignored_patterns: GraphPattern) -> set[str]:
+def get_node_names_matching_graph_pattern(nncf_graph: NNCFGraph, graph_pattern: GraphPattern) -> set[str]:
     """
-    Returns node names matched ignored_patterns.
+    Returns the names of nodes in the given NNCFGraph that match the specified graph pattern.
 
-    :param nncf_graph: NNCFGraph instance.
-    :param ignored_patterns: Ignored patterns.
-    :return: A set of NNCF node names from the given NNCFGraph matched ignored_patterns.
+    :param nncf_graph: An instance of NNCFGraph to search for matching subgraphs.
+    :param graph_pattern: A GraphPattern instance used to identify matching subgraphs.
+    :return: A set of node names from the NNCFGraph that match the given graph pattern.
     """
     nncf_node_names = set()
-    for subgraph in nncf_graph.find_matching_subgraphs(ignored_patterns, strict=False):
+    for subgraph in nncf_graph.find_matching_subgraphs(graph_pattern, strict=False):
         for nncf_node in subgraph:
             nncf_node_names.add(nncf_node.node_name)
     return nncf_node_names

src/nncf/quantization/algorithms/min_max/algorithm.py

@@ -22,7 +22,7 @@
 from nncf.common.factory import ModelTransformerFactory
 from nncf.common.graph.graph import NNCFGraph
 from nncf.common.graph.graph import NNCFNode
-from nncf.common.graph.graph import get_ignored_names_by_ignored_patterns
+from nncf.common.graph.graph import get_node_names_matching_graph_pattern
 from nncf.common.graph.operator_metatypes import OperatorMetatype
 from nncf.common.graph.patterns import GraphPattern
 from nncf.common.graph.patterns.manager import PatternsManager
@@ -586,7 +586,7 @@ def _get_ignored_names(
         user_ignored_names = get_ignored_node_names_from_ignored_scope(
             self._ignored_scope, nncf_graph, strict=self._ignored_scope.validate
         )
-        autogenerated_ignored_names = get_ignored_names_by_ignored_patterns(inference_nncf_graph, ignored_patterns)
+        autogenerated_ignored_names = get_node_names_matching_graph_pattern(inference_nncf_graph, ignored_patterns)
         autogenerated_ignored_names |= self._backend_entity.get_ignored_names_by_layer_attributes(inference_nncf_graph)
         autogenerated_ignored_names |= self._get_ignored_names_by_algorithm(inference_nncf_graph)
         ignored_names = {name: IgnoreReason.AUTOGENERATED for name in autogenerated_ignored_names}

src/nncf/quantization/algorithms/weight_compression/algorithm.py

@@ -20,7 +20,7 @@
 from nncf.common.factory import StatisticsAggregatorFactory
 from nncf.common.graph.graph import NNCFGraph
 from nncf.common.graph.graph import NNCFNode
-from nncf.common.graph.graph import get_ignored_names_by_ignored_patterns
+from nncf.common.graph.graph import get_node_names_matching_graph_pattern
 from nncf.common.graph.transformations.commands import TargetType
 from nncf.common.logging import nncf_logger
 from nncf.common.logging.track_progress import track
@@ -385,10 +385,10 @@ def get_nodes_to_compress(self, nncf_graph: NNCFGraph) -> list[NNCFNode]:
             self._ignored_scope, nncf_graph, strict=self._ignored_scope.validate
         )
 
-        ignored_patterns_names = get_ignored_names_by_ignored_patterns(
+        autogenerated_ignored_names = get_node_names_matching_graph_pattern(
             nncf_graph, self._backend_entity.get_ignored_patterns()
         )
-        ignored_names = ignored_names.union(ignored_patterns_names)
+        ignored_names = ignored_names.union(autogenerated_ignored_names)
 
         for node in nncf_graph.topological_sort():
             is_node_with_weights = self._backend_entity.is_node_with_weights(node, nncf_graph)