disable cpplint by default; upd .clang-format; add checks for python extensions

Author: ivikhrev

cmake/cpplint/cpplint_run.cmake

@@ -48,6 +48,6 @@ if(NOT SKIP_RETURN_CODE)
     if(NOT result EQUAL "0")
         # Display the cpplint output to console (to parse it form IDE)
         message("${output}")
-        message(WARNING "[cpplint] Code style check failed for : ${INPUT_FILE}")
+        message(FATAL_ERROR "[cpplint] Code style check failed for : ${INPUT_FILE}")
     endif()
 endif()

demos/CMakeLists.txt

@@ -18,7 +18,7 @@ project(Demos)
 include (CMakeDependentOption)
 
 cmake_dependent_option(ENABLE_CLANG_FORMAT "Enable clang-format checks during the build" ON "UNIX" OFF)
-option(ENABLE_CPPLINT "Enable cpplint checks during the build" ON)
+option(ENABLE_CPPLINT "Enable cpplint checks during the build" OFF)
 option(ENABLE_PYTHON "Whether to build extension modules for Python demos" OFF)
 option(MULTICHANNEL_DEMO_USE_TBB "Use TBB-based threading in multichannel demos" OFF)
 option(MULTICHANNEL_DEMO_USE_NATIVE_CAM "Use native camera api in multichannel demos" OFF)

demos/classification_benchmark_demo/cpp/CMakeLists.txt

@@ -8,4 +8,4 @@ file(GLOB_RECURSE SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/*.cpp)
 add_demo(NAME classification_benchmark_demo
     SOURCES ${SOURCES}
     HEADERS ${HEADERS}
-    DEPENDENCIES monitors models pipelines)
+    DEPENDENCIES monitors models pipelines)

demos/common/python/monitors_extension/CMakeLists.txt

@@ -1,13 +1,20 @@
-# Copyright (C) 2018-2019 Intel Corporation
+# Copyright (C) 2018-2022 Intel Corporation
 # SPDX-License-Identifier: Apache-2.0
 #
 
+set(TARGET_NAME "monitors_extension")
+
 find_package(OpenCV 4 REQUIRED COMPONENTS core)
 
-add_library(monitors_extension MODULE monitors_extension.cpp)
-target_include_directories(monitors_extension PRIVATE ${PYTHON_INCLUDE_DIRS} ${NUMPY_INCLUDE_DIR})
-target_link_libraries(monitors_extension PRIVATE ${PYTHON_LIBRARIES} opencv_core monitors utils)
-set_target_properties(monitors_extension PROPERTIES PREFIX "")
+add_library(${TARGET_NAME} MODULE  ${CMAKE_CURRENT_SOURCE_DIR}/monitors_extension.cpp)
+
+check_code_style(NAME ${TARGET_NAME}
+    CLANG_FORMAT ${ENABLE_CLANG_FORMAT}
+    CPPLINT ${ENABLE_CPPLINT})
+
+target_include_directories(${TARGET_NAME} PRIVATE ${PYTHON_INCLUDE_DIRS} ${NUMPY_INCLUDE_DIR})
+target_link_libraries(${TARGET_NAME} PRIVATE ${PYTHON_LIBRARIES} opencv_core monitors utils)
+set_target_properties(${TARGET_NAME} PROPERTIES PREFIX "")
 if(WIN32)
-    set_target_properties(monitors_extension PROPERTIES SUFFIX ".pyd")
+    set_target_properties(${TARGET_NAME} PROPERTIES SUFFIX ".pyd")
 endif()

demos/crossroad_camera_demo/cpp/CMakeLists.txt

@@ -8,4 +8,4 @@ file(GLOB_RECURSE HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/*.hpp)
 add_demo(NAME crossroad_camera_demo
     SOURCES "${SOURCES}"
     HEADERS "${HEADERS}"
-    DEPENDENCIES monitors)
+    DEPENDENCIES monitors)

demos/human_pose_estimation_3d_demo/python/pose_extractor/CMakeLists.txt

@@ -4,14 +4,22 @@
 
 find_package(OpenCV 4 REQUIRED COMPONENTS core imgproc)
 
-set(target_name pose_extractor)
-add_library(${target_name} MODULE wrapper.cpp
-                                  src/extract_poses.hpp src/extract_poses.cpp
-                                  src/human_pose.hpp src/human_pose.cpp
-                                  src/peak.hpp src/peak.cpp)
-target_include_directories(${target_name} PRIVATE src/ ${PYTHON_INCLUDE_DIRS} ${NUMPY_INCLUDE_DIR})
-target_link_libraries(${target_name} ${PYTHON_LIBRARIES} opencv_core opencv_imgproc)
-set_target_properties(${target_name} PROPERTIES PREFIX "")
+set(TARGET_NAME pose_extractor)
+add_library(${TARGET_NAME} MODULE  ${CMAKE_CURRENT_SOURCE_DIR}/wrapper.cpp
+                                   ${CMAKE_CURRENT_SOURCE_DIR}/src/extract_poses.hpp
+                                   ${CMAKE_CURRENT_SOURCE_DIR}/src/extract_poses.cpp
+                                   ${CMAKE_CURRENT_SOURCE_DIR}/src/human_pose.hpp
+                                   ${CMAKE_CURRENT_SOURCE_DIR}/src/human_pose.cpp
+                                   ${CMAKE_CURRENT_SOURCE_DIR}/src/peak.hpp
+                                   ${CMAKE_CURRENT_SOURCE_DIR}/src/peak.cpp)
+
+check_code_style(NAME ${TARGET_NAME}
+    CLANG_FORMAT ${ENABLE_CLANG_FORMAT}
+    CPPLINT ${ENABLE_CPPLINT})
+
+target_include_directories(${TARGET_NAME} PRIVATE src/ ${PYTHON_INCLUDE_DIRS} ${NUMPY_INCLUDE_DIR})
+target_link_libraries(${TARGET_NAME} ${PYTHON_LIBRARIES} opencv_core opencv_imgproc)
+set_target_properties(${TARGET_NAME} PROPERTIES PREFIX "")
 if(WIN32)
-    set_target_properties(${target_name} PROPERTIES SUFFIX ".pyd")
+    set_target_properties(${TARGET_NAME} PROPERTIES SUFFIX ".pyd")
 endif()

demos/speech_recognition_deepspeech_demo/python/ctcdecode-numpy/CMakeLists.txt

@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: Apache-2.0
 #
 
-set(target_name ctcdecode_numpy_impl)
+set(TARGET_NAME ctcdecode_numpy_impl)
 
 file(GLOB_RECURSE HEADERS
     "${CMAKE_CURRENT_SOURCE_DIR}/*.h" "${CMAKE_CURRENT_SOURCE_DIR}/*.hpp")
@@ -11,31 +11,35 @@ file(GLOB_RECURSE SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/*.cpp")
 source_group("include" FILES ${HEADERS})
 source_group("src" FILES ${SOURCES})
 
-add_library(${target_name} MODULE ${HEADERS} ${SOURCES})
+add_library(${TARGET_NAME} MODULE ${HEADERS} ${SOURCES})
 
-target_include_directories(${target_name} PRIVATE
+# check_code_style(NAME ${TARGET_NAME}
+#     CLANG_FORMAT ${ENABLE_CLANG_FORMAT}
+#     CPPLINT ${ENABLE_CPPLINT})
+
+target_include_directories(${TARGET_NAME} PRIVATE
     ${PYTHON_INCLUDE_DIRS} ${NUMPY_INCLUDE_DIR} third_party/ThreadPool)
-target_link_libraries(${target_name} ${PYTHON_LIBRARIES})
+target_link_libraries(${TARGET_NAME} ${PYTHON_LIBRARIES})
 
-set_target_properties(${target_name} PROPERTIES
+set_target_properties(${TARGET_NAME} PROPERTIES
     PREFIX ""
     OUTPUT_NAME _impl
 )
 
 if(WIN32)
-    set_target_properties(${target_name} PROPERTIES SUFFIX ".pyd")
+    set_target_properties(${TARGET_NAME} PROPERTIES SUFFIX ".pyd")
 endif()
 
 foreach(artifact IN ITEMS ARCHIVE LIBRARY PDB RUNTIME)
-    set_property(TARGET ${target_name} APPEND_STRING
+    set_property(TARGET ${TARGET_NAME} APPEND_STRING
         PROPERTY "${artifact}_OUTPUT_DIRECTORY" "/ctcdecode_numpy")
 endforeach()
 
 # SWIG-generated code causes some warnings; disable them.
 if(COMPILER_IS_GCC_LIKE)
-    target_compile_options(${target_name} PRIVATE -Wno-narrowing)
+    target_compile_options(${TARGET_NAME} PRIVATE -Wno-narrowing)
 elseif(MSVC)
-    target_compile_options(${target_name} PRIVATE
+    target_compile_options(${TARGET_NAME} PRIVATE
         /wd4244  # Disable conversion warning =
         /wd4838  # Disable conversion warning in aggregate or list initialization
     )
@@ -52,8 +56,8 @@ add_custom_target(ctcdecode_numpy ALL
     COMMAND "${CMAKE_COMMAND}" -E copy_if_different
         "${CMAKE_CURRENT_SOURCE_DIR}/ctcdecode_numpy/__init__.py"
         "${CMAKE_CURRENT_SOURCE_DIR}/ctcdecode_numpy/impl.py"
-        "$<TARGET_FILE_DIR:${target_name}>"
+        "$<TARGET_FILE_DIR:${TARGET_NAME}>"
     VERBATIM
 )
 
-add_dependencies(ctcdecode_numpy ${target_name})
+add_dependencies(ctcdecode_numpy ${TARGET_NAME})