Merge pull request #3377 from ivikhrev/fix-warnings

fix clang warnings

Author: Wovchena

demos/background_subtraction_demo/cpp_gapi/include/custom_kernels.hpp

@@ -33,6 +33,8 @@ G_API_OP(GCalculateMaskRCNNBGMask,
 
 class NNBGReplacer {
 public:
+    NNBGReplacer() = default;
+    virtual ~NNBGReplacer() = default;
     NNBGReplacer(const std::string& model_path);
     virtual cv::GMat replace(cv::GMat, const cv::Size&, cv::GMat) = 0;
     const std::string& getName() { return m_tag; }

demos/common/cpp/models/src/detection_model_ssd.cpp

@@ -259,7 +259,8 @@ void ModelSSD::prepareMultipleOutputs(std::shared_ptr<ov::Model>& model) {
         }
     }
     else {
-        throw std::logic_error("Incorrect number of 'boxes' output dimensions, expected 2 or 3, but had " + boxesShape.size());
+        throw std::logic_error("Incorrect number of 'boxes' output dimensions, expected 2 or 3, but had "
+            + std::to_string(boxesShape.size()));
     }
 
     ppp.output(outputsNames[0]).tensor().

demos/common/cpp/models/src/detection_model_yolo.cpp

@@ -131,7 +131,7 @@ void ModelYolo::prepareInputsOutputs(std::shared_ptr<ov::Model>& model) {
 
     yoloVersion = YOLO_V3;
     bool isRegionFound = false;
-    for (const auto op : model->get_ordered_ops()) {
+    for (const auto& op : model->get_ordered_ops()) {
         if (std::string("RegionYolo") == op->get_type_name()) {
             auto regionYolo = std::dynamic_pointer_cast<ov::op::v0::RegionYolo>(op);
 
@@ -141,7 +141,7 @@ void ModelYolo::prepareInputsOutputs(std::shared_ptr<ov::Model>& model) {
                 }
 
                 const auto& opName = op->get_friendly_name();
-                for (const auto out : outputs) {
+                for (const auto& out : outputs) {
                     if (out.get_node()->get_friendly_name() == opName ||
                         out.get_node()->get_input_node_ptr(0)->get_friendly_name() == opName) {
                         isRegionFound = true;

demos/common/cpp/utils/include/utils/common.hpp

@@ -172,7 +172,7 @@ inline void logBasicModelInfo(const std::shared_ptr<ov::Model>& model) {
     ov::OutputVector outputs = model->outputs();
 
     slog::info << "\tInputs: " << slog::endl;
-    for (const ov::Output<ov::Node> input : inputs) {
+    for (const ov::Output<ov::Node>& input : inputs) {
         const std::string name = input.get_any_name();
         const ov::element::Type type = input.get_element_type();
         const ov::PartialShape shape = input.get_partial_shape();

demos/common/cpp/utils/include/utils/shared_tensor_allocator.hpp

@@ -19,7 +19,13 @@
 #include <opencv2/core.hpp>
 #include <openvino/runtime/allocator.hpp>
 
-class SharedTensorAllocator : public ov::AllocatorImpl {
+// To prevent false-positive clang compiler warning
+// (https://github.com/openvinotoolkit/openvino/pull/11092#issuecomment-1073846256):
+// warning: destructor called on non-final 'SharedTensorAllocator' that has virtual functions
+// but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
+// SharedTensorAllocator class declared as final
+
+class SharedTensorAllocator final : public ov::AllocatorImpl {
 public:
     SharedTensorAllocator(const cv::Mat& img) : img(img) {}
 

demos/gesture_recognition_demo/cpp_gapi/include/stream_source.hpp

@@ -190,7 +190,7 @@ class GestRecCapSource : public cv::gapi::wip::IStreamSource {
         }
 
         /** Put pulled batch to GRunArg data **/
-        cv::detail::VectorRef ref(std::move(producer.getBatch()));
+        cv::detail::VectorRef ref(producer.getBatch());
         data = std::move(ref);
         return true;
     }

demos/gesture_recognition_demo/cpp_gapi/main.cpp

@@ -155,7 +155,7 @@ int main(int argc, char *argv[]) {
         bool isStart = true;
         const auto startTime = std::chrono::steady_clock::now();
         pipeline.start();
-        while (pipeline.pull(std::move(cv::gout(out_frame, out_detections, out_label_number)))) {
+        while (pipeline.pull(cv::gout(out_frame, out_detections, out_label_number))) {
             /** Put FPS to frame**/
             if (isStart) {
                 metrics.update(startTime, out_frame, { 10, 22 }, cv::FONT_HERSHEY_COMPLEX,

demos/gesture_recognition_demo/cpp_gapi/src/custom_kernels.cpp

@@ -202,7 +202,7 @@ GAPI_OCV_KERNEL(OCVGestureRecognitionPostprocessing, custom::GestureRecognitionP
             int minIdx = 0, maxIdx = 0;
             const float* data = asl_result[0].ptr<float>();
             // Find more suitable action
-            cv::minMaxIdx(asl_result[0].reshape(1, {int(asl_result[0].total())}), &min, &max, &minIdx, &maxIdx);
+            cv::minMaxIdx(asl_result[0].reshape(1, int(asl_result[0].total())), &min, &max, &minIdx, &maxIdx);
             if (data[maxIdx] > ar_threshold) {
                 label_number = maxIdx;
             }

demos/interactive_face_detection_demo/cpp_gapi/visualizer.cpp

@@ -13,7 +13,7 @@ EmotionBarVisualizer::EmotionBarVisualizer(std::vector<std::string> const& emoti
                                            double textScale,
                                            int textThickness):
     emotionNames(emotionNames), size(size), padding(padding), opacity(opacity),
-    textScale(textScale), textThickness(textThickness), internalPadding(0) {
+    textScale(textScale), textThickness(textThickness) {
     auto itMax = std::max_element(emotionNames.begin(), emotionNames.end(), [] (std::string const& lhs, std::string const& rhs) {
         return lhs.length() < rhs.length();
     });

demos/interactive_face_detection_demo/cpp_gapi/visualizer.hpp

@@ -37,7 +37,6 @@ class EmotionBarVisualizer {
     double opacity;
     double textScale;
     int textThickness;
-    int internalPadding;
 };
 
 // Drawing a photo frame around detected face