Skip to content

Commit 7ddab17

Browse files
mhpanahLyamin-Romanp-durandin
authored
[Coverity] Medium issues in GPU Plugin (#30447)
### Details: - Fixing 1565213, 1565100, 1565332 - Other issues are already fixed ### Changes: - Initialized the default `m_compressed` value to false - Null pointer dereferences: ensure `compressed_cache_variable` is not NULL - Ensure result is float ### Tickets: - *CVS-157248* --------- Co-authored-by: Roman Lyamin <[email protected]> Co-authored-by: Pavel Durandin <[email protected]>
1 parent 6b2ca78 commit 7ddab17

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

src/plugins/intel_gpu/include/intel_gpu/op/kv_cache_compressed.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class KVCacheCompressed : public ov::intel_gpu::op::KVCache {
4242
std::vector<uint64_t> get_scales_zp_output_order() const { return m_quantization_attrs.scales_zp_output_order; }
4343

4444
private:
45-
bool m_compressed;
45+
bool m_compressed = false;
4646
QuantizationAttrs m_quantization_attrs = {};
4747
};
4848

src/plugins/intel_gpu/src/graph/primitive_inst.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1402,6 +1402,7 @@ void primitive_inst::do_runtime_in_place_kv_cache() {
14021402

14031403
if (desc->compressed) {
14041404
auto compressed_cache_variable = dynamic_cast<ov::intel_gpu::VariableStateIndirectKVCacheCompressed*>(&variable);
1405+
OPENVINO_ASSERT(compressed_cache_variable != nullptr, "[GPU] compressed_cache_variable is null");
14051406
auto& present_scales_layout = _impl_params->output_layouts[2];
14061407
const auto sequence_axis = kv_cache_inst::get_scale_zp_sequence_axis();
14071408
kv_cache_inst::update_pad(present_scales_layout, max_pad - new_seq_len, sequence_axis);

src/plugins/intel_gpu/src/kernel_selector/kernels/convolution/convolution_kernel_b_fs_zyx_fsv16_imad.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ float Convolution_kernel_b_fs_zyx_fsv16_imad::EstimateBlockParamsRatio(const con
186186
return -10.f;
187187
}
188188

189-
float occupancy_by_logic_size = static_cast<float>(params.outputs[0].LogicalSize() / static_cast<size_t>(params.engineInfo.maxThreadsPerDevice));
189+
float occupancy_by_logic_size = static_cast<float>(params.outputs[0].LogicalSize()) / static_cast<float>(params.engineInfo.maxThreadsPerDevice);
190190
bool increase_max_reg_pressure = occupancy_by_logic_size >= 595.f;
191191
bool twice_increase_max_reg_pressure = occupancy_by_logic_size >= 595.f * 2.f;
192192
float max_reg_pressure = twice_increase_max_reg_pressure ? 0.785f : increase_max_reg_pressure ? 0.75f : 0.7f;

0 commit comments

Comments
 (0)