refactor: flip args

HrikB · HrikB · commit 958c96cb931d · 2025-03-19T17:04:07.000-04:00
diff --git a/src/OpenVmHalo2Verifier.sol b/src/OpenVmHalo2Verifier.sol
@@ -44,8 +44,8 @@ abstract contract OpenVmHalo2Verifier {
     /// is being verified.
     /// @param leafExeCommit The commitment to the leaf verifier.
     function verifyProof(
-        bytes calldata partialProof,
         bytes calldata guestPvs,
+        bytes calldata partialProof,
         bytes32 appExeCommit,
         bytes32 leafExeCommit
     ) external view {
diff --git a/test/OpenVmHalo2Verifier.t.sol b/test/OpenVmHalo2Verifier.t.sol
@@ -26,7 +26,7 @@ contract OpenVmHalo2VerifierTest is Test, OpenVmHalo2Verifier {
     }
 
     function test_proofFormat() public view {
-        this.verifyProof(partialProof, abi.encodePacked(guestPvsHash), appExeCommit, leafExeCommit);
+        this.verifyProof(abi.encodePacked(guestPvsHash), partialProof, appExeCommit, leafExeCommit);
     }
 
     function testFuzz_proofFormat(
@@ -55,7 +55,7 @@ contract OpenVmHalo2VerifierTest is Test, OpenVmHalo2Verifier {
 
     function test_RevertWhen_InvalidPartialProofLength() public {
         vm.expectRevert(abi.encodeWithSelector(OpenVmHalo2Verifier.InvalidPartialProofLength.selector));
-        this.verifyProof(hex"aa", abi.encodePacked(guestPvsHash), appExeCommit, leafExeCommit);
+        this.verifyProof(abi.encodePacked(guestPvsHash), hex"aa", appExeCommit, leafExeCommit);
     }
 
     function test_RevertWhen_InvalidGuestPvsLength() public {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ contract OpenVmHalo2VerifierTest is Test, OpenVmHalo2Verifier {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`function test_proofFormat() public view {`
`29`		`- this.verifyProof(partialProof, abi.encodePacked(guestPvsHash), appExeCommit, leafExeCommit);`
	`29`	`+ this.verifyProof(abi.encodePacked(guestPvsHash), partialProof, appExeCommit, leafExeCommit);`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`function testFuzz_proofFormat(`
`@@ -55,7 +55,7 @@ contract OpenVmHalo2VerifierTest is Test, OpenVmHalo2Verifier {`
`55`	`55`
`56`	`56`	`function test_RevertWhen_InvalidPartialProofLength() public {`
`57`	`57`	`vm.expectRevert(abi.encodeWithSelector(OpenVmHalo2Verifier.InvalidPartialProofLength.selector));`
`58`		`- this.verifyProof(hex"aa", abi.encodePacked(guestPvsHash), appExeCommit, leafExeCommit);`
	`58`	`+ this.verifyProof(abi.encodePacked(guestPvsHash), hex"aa", appExeCommit, leafExeCommit);`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`function test_RevertWhen_InvalidGuestPvsLength() public {`