fix(new-execution): assign bls12_381 output properly (#1895)

Author: shuklaayush

extensions/algebra/circuit/src/fields.rs

@@ -281,6 +281,7 @@ pub fn field_element_to_blocks<F: PrimeField<Repr = [u8; 32]>, const BLOCK_SIZE:
     field_element: &F,
     output: &mut [[u8; BLOCK_SIZE]],
 ) {
+    debug_assert!(output.len() * BLOCK_SIZE == 32);
     let bytes = field_element.to_repr();
     let mut byte_idx = 0;
 
@@ -312,6 +313,7 @@ pub fn field_element_to_blocks_bls12_381_coordinate<const BLOCK_SIZE: usize>(
     field_element: &halo2curves_axiom::bls12_381::Fq,
     output: &mut [[u8; BLOCK_SIZE]],
 ) {
+    debug_assert!(output.len() * BLOCK_SIZE == 48);
     let bytes = field_element.to_bytes();
     let mut byte_idx = 0;
 

extensions/ecc/circuit/src/weierstrass_chip/curves.rs

@@ -170,8 +170,8 @@ fn ec_double_bls12_381<const BLOCKS: usize, const BLOCK_SIZE: usize>(
 
     // Final output
     let mut output = [[0u8; BLOCK_SIZE]; BLOCKS];
-    field_element_to_blocks_bls12_381_coordinate(&x3, &mut output);
-    field_element_to_blocks_bls12_381_coordinate(&y3, &mut output);
+    field_element_to_blocks_bls12_381_coordinate(&x3, &mut output[..BLOCKS / 2]);
+    field_element_to_blocks_bls12_381_coordinate(&y3, &mut output[BLOCKS / 2..]);
     output
 }