Skip to content

Commit 4561100

Browse files
authored
1 parent 92d4478 commit 4561100

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

.github/workflows/versioning.yml

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737

3838
# Build and test from base branch
3939
- name: Build base branch CLI
40-
run: cargo install --force --path crates/cli
40+
run: cargo install --force --locked --path crates/cli
4141

4242
- name: Run setup from base branch and snapshot ~/.openvm
4343
run: |
@@ -81,12 +81,11 @@ jobs:
8181
clean: false
8282

8383
- name: Build tagged CLI
84-
run: cargo install --force --path crates/cli
84+
run: cargo install --force --locked --path crates/cli
8585

8686
- name: Run setup from tagged version
8787
run: |
88-
# TODO: Add --evm after v1.3.0 release
89-
cargo openvm setup
88+
cargo openvm setup --evm
9089
9190
# - name: Build and keygen examples from tagged version
9291
# run: |
@@ -97,9 +96,8 @@ jobs:
9796
# echo "Building and generating keys for example: $example_name"
9897
# cd "$example"
9998
# cargo openvm build --no-transpile
100-
# # TODO(yi): Change --vk-output to --output-dir after v1.3.0 release
10199
# mkdir -p "../../tagged-outputs/examples/$example_name"
102-
# cargo openvm keygen --vk-output "../../tagged-outputs/examples/$example_name/app.vk"
100+
# cargo openvm keygen --output-dir "../../tagged-outputs/examples/$example_name/app.vk"
103101
# cd ../..
104102
# fi
105103
# done
@@ -113,9 +111,8 @@ jobs:
113111
echo "Building and generating keys for benchmark: $benchmark_name"
114112
cd "$benchmark"
115113
cargo openvm build --no-transpile
116-
# TODO(yi): Change --vk-output to --output-dir after v1.3.0 release
117114
mkdir -p "../../../tagged-outputs/benchmarks/$benchmark_name"
118-
cargo openvm keygen --vk-output "../../../tagged-outputs/benchmarks/$benchmark_name/app.vk"
115+
cargo openvm keygen --output-dir "../../../tagged-outputs/benchmarks/$benchmark_name"
119116
cd ../../..
120117
fi
121118
done
@@ -167,19 +164,25 @@ jobs:
167164
fi
168165
169166
# Compare all outputs
170-
# TODO: After v1.3.0 release, just compare the contents of ~/.openvm-base
171-
# and ~/.openvm
172167
- name: Compare ~/.openvm contents
173168
run: |
174169
echo "🔍 Comparing ~/.openvm agg and halo2 outputs between base branch and ${{ env.version }}..."
175170
176171
failed=0
177172
178-
# Compare agg.pk with agg_halo2.pk
179-
if cmp ~/.openvm-base/agg.pk ~/.openvm/agg_halo2.pk; then
180-
echo "✅ agg.pk and agg_halo2.pk are identical"
173+
# Compare agg_stark.pk
174+
if cmp ~/.openvm-base/agg_stark.pk ~/.openvm/agg_stark.pk; then
175+
echo "✅ agg_stark.pk are identical"
176+
else
177+
echo "❌ agg_stark.pk differ"
178+
failed=1
179+
fi
180+
181+
# Compare agg_halo2.pk
182+
if cmp ~/.openvm-base/agg_halo2.pk ~/.openvm/agg_halo2.pk; then
183+
echo "✅ agg_halo2.pk are identical"
181184
else
182-
echo "❌ agg.pk and agg_halo2.pk differ"
185+
echo "❌ agg_halo2.pk differ"
183186
failed=1
184187
fi
185188

0 commit comments

Comments
 (0)