Skip to content

Commit 55b26a1

Browse files
authored
ci(new-execution): use proper jemalloc settings for execute benchmarks (#1944)
1 parent e67deab commit 55b26a1

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/workflows/benchmarks-execute.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ concurrency:
2626
env:
2727
CARGO_TERM_COLOR: always
2828
S3_FIXTURES_PATH: s3://openvm-public-data-sandbox-us-east-1/benchmark/fixtures
29+
JEMALLOC_SYS_WITH_MALLOC_CONF: "retain:true,background_thread:true,metadata_thp:always,thp:always,dirty_decay_ms:-1,muzzy_decay_ms:-1,abort_conf:true"
2930

3031
jobs:
3132
codspeed-walltime-benchmarks:
@@ -71,8 +72,6 @@ jobs:
7172
working-directory: benchmarks/execute
7273
run: cargo codspeed run
7374
token: ${{ secrets.CODSPEED_TOKEN }}
74-
env:
75-
CODSPEED_RUNNER_MODE: walltime
7675

7776
codspeed-instrumentation-benchmarks:
7877
name: Run codspeed instrumentation benchmarks
@@ -118,5 +117,3 @@ jobs:
118117
working-directory: benchmarks/execute
119118
run: cargo codspeed run
120119
token: ${{ secrets.CODSPEED_TOKEN }}
121-
env:
122-
CODSPEED_RUNNER_MODE: instrumentation

crates/vm/src/system/memory/offline_checker/columns.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ pub struct MemoryBaseAuxCols<T> {
2020
}
2121

2222
impl<F: PrimeField32> MemoryBaseAuxCols<F> {
23+
#[inline(always)]
2324
pub fn set_prev(&mut self, prev_timestamp: F) {
2425
self.prev_timestamp = prev_timestamp;
2526
}
@@ -37,15 +38,18 @@ impl<const N: usize, T> MemoryWriteAuxCols<T, N> {
3738
Self { base, prev_data }
3839
}
3940

41+
#[inline(always)]
4042
pub fn get_base(self) -> MemoryBaseAuxCols<T> {
4143
self.base
4244
}
4345

46+
#[inline(always)]
4447
pub fn prev_data(&self) -> &[T; N] {
4548
&self.prev_data
4649
}
4750

4851
/// Sets the previous data **without** updating the less than auxiliary columns.
52+
#[inline(always)]
4953
pub fn set_prev_data(&mut self, data: [T; N]) {
5054
self.prev_data = data;
5155
}
@@ -71,11 +75,13 @@ impl<F: PrimeField32> MemoryReadAuxCols<F> {
7175
}
7276
}
7377

78+
#[inline(always)]
7479
pub fn get_base(self) -> MemoryBaseAuxCols<F> {
7580
self.base
7681
}
7782

7883
/// Sets the previous timestamp **without** updating the less than auxiliary columns.
84+
#[inline(always)]
7985
pub fn set_prev(&mut self, timestamp: F) {
8086
self.base.prev_timestamp = timestamp;
8187
}

0 commit comments

Comments
 (0)