WIP

Author: Avaneesh-axiom

Cargo.lock

@@ -56,6 +56,7 @@ members = [
     "extensions/ecc/transpiler",
     "extensions/ecc/guest",
     "extensions/ecc/sw-setup",
+    "extensions/ecc/te-setup",
     "extensions/ecc/tests",
     "extensions/pairing/circuit",
     "extensions/pairing/transpiler",
@@ -153,6 +154,7 @@ openvm-ecc-circuit = { path = "extensions/ecc/circuit", default-features = false
 openvm-ecc-transpiler = { path = "extensions/ecc/transpiler", default-features = false }
 openvm-ecc-guest = { path = "extensions/ecc/guest", default-features = false }
 openvm-ecc-sw-setup = { path = "extensions/ecc/sw-setup", default-features = false }
+openvm-ecc-te-setup = { path = "extensions/ecc/te-setup", default-features = false }
 openvm-pairing-circuit = { path = "extensions/pairing/circuit", default-features = false }
 openvm-pairing-transpiler = { path = "extensions/pairing/transpiler", default-features = false }
 openvm-pairing-guest = { path = "extensions/pairing/guest", default-features = false }

Cargo.toml

@@ -1,5 +1,6 @@
-use std::{cell::RefCell, ops::Deref, rc::Rc};
+use std::{cell::RefCell, iter, ops::Deref, rc::Rc};
 
+use itertools::zip_eq;
 use num_bigint_dig::{BigInt, BigUint, Sign};
 use num_traits::Zero;
 use openvm_circuit_primitives::{
@@ -209,6 +210,9 @@ pub struct FieldExpr {
     pub check_carry_mod_to_zero: CheckCarryModToZeroSubAir,
 
     pub range_bus: VariableRangeCheckerBus,
+
+    // any values other than the prime modulus that need to be checked at setup
+    pub setup_values: Vec<BigUint>,
 }
 
 impl FieldExpr {
@@ -229,8 +233,20 @@ impl FieldExpr {
             builder,
             check_carry_mod_to_zero: subair,
             range_bus,
+            setup_values: vec![],
         }
     }
+
+    pub fn new_with_setup_values(
+        builder: ExprBuilder,
+        range_bus: VariableRangeCheckerBus,
+        needs_setup: bool,
+        setup_values: Vec<BigUint>,
+    ) -> Self {
+        let mut ret = Self::new(builder, range_bus, needs_setup);
+        ret.setup_values = setup_values;
+        ret
+    }
 }
 
 impl Deref for FieldExpr {
@@ -290,6 +306,22 @@ impl<AB: InteractionBuilder> SubAir<AB> for FieldExpr {
             let is_setup = flags.iter().fold(is_valid.into(), |acc, &x| acc - x);
             builder.assert_bool(is_setup.clone());
             builder.when_first_row().assert_one(is_setup.clone());
+
+            /*
+            for (lhs, rhs) in zip_eq(
+                inputs.iter().flatten(),
+                iter::empty().chain(self.builder.prime_limbs.clone()).chain(
+                    self.setup_values.iter().flat_map(|value| {
+                        big_uint_to_num_limbs(value, self.builder.limb_bits, self.builder.num_limbs)
+                    }),
+                ),
+            ) {
+                builder
+                    .when(is_setup.clone())
+                    .assert_eq(*lhs, AB::F::from_canonical_usize(rhs));
+            }
+            */
+
             for i in 0..inputs[0].len().max(self.builder.prime_limbs.len()) {
                 let lhs = if i < inputs[0].len() {
                     inputs[0][i].into()

crates/circuits/mod-builder/src/builder.rs

@@ -286,24 +286,40 @@ where
         &self.air
     }
 
+    // TODO: add support to pad with setup row.
     fn finalize(&self, trace: &mut RowMajorMatrix<F>, num_records: usize) {
         if !self.should_finalize || num_records == 0 {
             return;
         }
-        // We will copy over the core part of last row to padded rows (all rows after num_records).
-        let core_width = <Self::Air as BaseAir<F>>::width(&self.air);
-        let adapter_width = trace.width() - core_width;
-        let last_row = trace
-            .rows()
-            .nth(num_records - 1)
-            .unwrap()
-            .collect::<Vec<_>>();
-        let last_row_core = last_row.split_at(adapter_width).1;
-        for row in trace.rows_mut().skip(num_records) {
-            let core_row = row.split_at_mut(adapter_width).1;
-            // The same as last row, except "is_valid" (the first element of core part) is zero.
-            core_row.copy_from_slice(last_row_core);
-            core_row[0] = F::ZERO;
+
+        if self.air.num_flags() == 0 {
+            // We will copy over the core part of last row to padded rows (all rows after num_records).
+            let core_width = <Self::Air as BaseAir<F>>::width(&self.air);
+            let adapter_width = trace.width() - core_width;
+            let last_row = trace
+                .rows()
+                .nth(num_records - 1)
+                .unwrap()
+                .collect::<Vec<_>>();
+            let last_row_core = last_row.split_at(adapter_width).1;
+            for row in trace.rows_mut().skip(num_records) {
+                let core_row = row.split_at_mut(adapter_width).1;
+                // The same as last row, except "is_valid" (the first element of core part) is zero.
+                core_row.copy_from_slice(last_row_core);
+                core_row[0] = F::ZERO;
+            }
+        } else {
+            // We will copy over the core part of first row to padded rows (all rows after num_records).
+            let core_width = <Self::Air as BaseAir<F>>::width(&self.air);
+            let adapter_width = trace.width() - core_width;
+            let first_row = trace.rows().nth(0).unwrap().collect::<Vec<_>>();
+            let first_row_core = first_row.split_at(adapter_width).1;
+            for row in trace.rows_mut().skip(num_records) {
+                let core_row = row.split_at_mut(adapter_width).1;
+                // The same as first row, except "is_valid" (the first element of core part) is zero.
+                core_row.copy_from_slice(first_row_core);
+                core_row[0] = F::ZERO;
+            }
         }
     }
 }

crates/circuits/mod-builder/src/core_chip.rs

@@ -0,0 +1 @@
+Twisted Edwards (te) curve operations