Skip to content

Commit a0ae88f

Browse files
authored
fix: several typos of different importance (#1627)
I know you don't acknowledge PR's with minor typo fixes, But I found some typos that should be fixed, and they are not subjective or minor ones.
1 parent 56f2b51 commit a0ae88f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

audits/v1-internal/extension-algebra.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ These should fail to verify, but they currently pass.
2929

3030
**Recommendation:**
3131
On setup rows, add the constraints `c_lt_mark = 2` and `sum_i lt_marker[i] = 2`.
32-
This (together with the existing contsraints) will ensure `lt_marker` has one 2 and that the remaining entries are 0s.
32+
This (together with the existing constraints) will ensure `lt_marker` has one 2 and that the remaining entries are 0s.
3333
Then modify the `b[i] = N[i]` constraint to constrain `b[i] = N[i]` when `prefix_sum` is not 1 or `final_sum - is_setup` (currently it applies the constraint when `prefix_sum` is not 1 or `final_sum`).
3434
On setup rows, `final_sum - is_setup = 2 - 1 = 1` and `prefix_sum` is 0 or 2 for all `i` so `b[i] = N[i]` will be constrained for all `i`.
3535
See the [soundness proof](#31-soundness-of-is_eq-chip) below for more details.

audits/v1-internal/extension-native.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Add the following constraints to `NativePoseidon2Air`:
3737
**Resolution:** https://github.com/openvm-org/openvm/pull/1435
3838
https://github.com/openvm-org/openvm/commit/d768af4de1500044a49ab642915174e83eb86bcb
3939

40-
### 2.2 NativePosiedon2Air constraints allow padding rows with `is_exhausted` cells
40+
### 2.2 NativePoseidon2Air constraints allow padding rows with `is_exhausted` cells
4141

4242
**Severity:** Medium
4343
**Context:** https://github.com/openvm-org/openvm/blob/830053d599606fd5c7dc8f8346710f9d6854beae/extensions/native/circuit/src/poseidon2/air.rs
@@ -50,7 +50,7 @@ However, all the attacker can do is effectively repeatedly apply the Poseidon2
5050
permutation to the final hash, which is unlikely to be useful in an attack.
5151

5252
**Recommendation:**
53-
Add a constraint that `is_exhausted[0] = 0` or simply remove the `is_exhasted[0]` variable.
53+
Add a constraint that `is_exhausted[0] = 0` or simply remove the `is_exhausted[0]` variable.
5454

5555
**Resolution:** https://github.com/openvm-org/openvm/pull/1436
5656
https://github.com/openvm-org/openvm/commit/2514e5d371d5706d22f573746213cd062eea4142
@@ -230,7 +230,7 @@ https://github.com/openvm-org/openvm/commit/960abb0b9edb8ef8bca3d62054a20fb3edf3
230230
## 3. Discussion
231231

232232
This review included all chips under `native/circuit/src` as well as
233-
`native/tranpsiler`.
233+
`native/transpiler`.
234234

235235
Aside from the issues found above, one observation from reviewing the AIRs is
236236
that the AIRs are not always consistent with whether or not they enforce if an

audits/v1-internal/isa.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Findings include anything that could warrant change or unexpected behavior that
1919

2020
**Context:** [link](https://cantina.xyz/code/c486d600-bed0-4fc6-aed1-de759fd29fa2/openvm/extensions/rv32im/circuit/src/adapters/loadstore.rs#L183)
2121

22-
**Description:** `Rv32LoadStoreChip` chip doesn't assert supoprted address spaces. An valid instruction could read from an address space which requires elements larger than 1 byte or write into an address space which requires elements smaller than 1 byte. This could break address space invariants which other chips take.
22+
**Description:** `Rv32LoadStoreChip` chip doesn't assert supported address spaces. An valid instruction could read from an address space which requires elements larger than 1 byte or write into an address space which requires elements smaller than 1 byte. This could break address space invariants which other chips take.
2323

2424
This could only happen when users intend to add some invalid instruction.
2525

0 commit comments

Comments
 (0)