New release

[TimoGlastra]

We would like to create a new release of the JavaScript wrapper including #399.

@andrewwhitehead can you create a new release?

[TimoGlastra]

Hey @andrewwhitehead, the issue 16KB page size is going to become a problem soon. Would it be possible to trigger a new release?

[genaris]

Is there a way to release a 0.3.3 version supporting the 16KB page size? It will be needed for Credo 0.5.x users (e.g. BCWallet).

[swcurran]

@genaris -- I've asked @andrewwhitehead about it. Do you know what is needed to enable the 16kb size? I keep hearing that it is urgently needed, but not what change is required. @andrewwhitehead may know, but for others like me, it might be helpful to describe the change.

[swcurran]

Ah...I think I see. We need a new release for an older version, because Credo 0.5.x can't update to the latest Askar? Is that right?

This will be fun...

[andrewwhitehead]

@genaris You mean something based on 0.3.2 with just the stack size update? I'm not sure if that will build successfully without other dependency updates but we can try on a new branch.

[genaris]

@genaris You mean something based on 0.3.2 with just the stack size update? I'm not sure if that will build successfully without other dependency updates but we can try on a new branch.

Yes, exactly. I know that some unexpected problems with the CI might appear (e.g. what happened to anoncreds-rs 😢) but as you say, we can give it a try on a new branch and see what happens...

[andrewwhitehead]

I built the assets from the build/v0.3.3 branch and verified the stack size using the check_elf_alignment.sh script (https://developer.android.com/guide/practices/page-sizes#elf-alignment). I also checked that it succeeds for v0.4.5 and fails for the v0.4.4 assets.

[andrewwhitehead]

The Python and npm publishing didn't succeed because I assume those processes had been updated in the meantime. Maybe the files you need are attached to the release though?

[swcurran]

@genaris -- sorry for the duplicate question to the one just asked for Credo. Does this enable PR/release get the "16kb" fix so that you can get it into Credo 0.5.x? Thanks!

[genaris]

I thought it was, but when trying to integrate in askar-javascript-wrapper and create a a drop-in replacement of the package for Credo 0.5.x I figured out there were some issues on the setup of that repo that messed up a bit the versioning (e.g. there is a JS wrapper 0.2.5 that uses askar binary 0.4.1 when it should stick to 0.3.x), so now it would be harder to release a 0.2.6 using this askar release.

In openwallet-foundation/askar-wrapper-javascript#55 (comment) @TimoGlastra mentioned:

Hmm i think it might be easier to just integrate the latest owf askar release into 0.5.x and support both askar interfaces in the 0.5.x stream. There's not a lot / any breaking api changes besides the naming ariesAskar vs askar.

By supporting both it won't be a breaking change, but it does allow 0.5.x users to move towards the new askar release

From Credo API perspective I think it is quite straightforward: Credo's Askar module receives on its config either an 'ariesAskar' or 'askar' object depending on the package used. Both openwallet-foundation and hyperledger packages are defined as peer dependencies, so either of them can be selected. But I guess some interesting work will be needed within Credo's Askar module code to adjust classes and types (e.g. KeyAlgs) to one or another depending on the one that is used. Is it something like this that you are envisioning @TimoGlastra ?

[TimoGlastra]

Yes exactly! I think we can depend on both the shared libs in Credo, and just use one or the other based on if askar or ariesAskar os registered (we can also detect it by running version method). KeyAlgs should not matter because the native values didn't change. We might need a few type casts.

[TimoGlastra]

I create a PR that integrates the latest Askar release into the 0.5.x branch: openwallet-foundation/credo-ts#2413