Skip to content
This repository was archived by the owner on Dec 20, 2023. It is now read-only.

Commit 1fe8c68

Browse files
authored
Merge pull request #605 from openweave/feature/delete-pwd
delete default test password
2 parents 5681a35 + c3b478c commit 1fe8c68

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

src/test-apps/happy/test-templates/ServiceAccountManager.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -167,17 +167,12 @@ def __pre_check(self):
167167
self.host = self.host.replace('home.', '')
168168

169169
if not self.username:
170-
self.username = "[email protected]"
171-
emsg = "ServiceAccountManager: using default weave_service_username %s." % (
172-
self.username)
173-
self.logger.debug(emsg)
170+
emsg = "ServiceAccountManager: please provide username"
171+
raise ValueError(emsg)
174172

175173
if not self.password:
176-
# Check if service password is set
177-
self.password = "nest-egg123"
178-
emsg = "ServiceAccountManager: using default weave_service_password %s." % (
179-
self.password)
180-
self.logger.debug(emsg)
174+
emsg = "ServiceAccountManager: please provide password"
175+
raise ValueError(emsg)
181176

182177
self.params = json.dumps(
183178
{'email': self.username, 'username': self.username, 'password': self.password})

src/test-apps/happy/tests/service/pairing/test_weave_pairing_01.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def setUp(self):
8585

8686
self.username = os.environ.get("WEAVE_USERNAME", "test-it+weave_happy_fabric%[email protected]" % self.fabric_id)
8787

88-
self.password = os.environ.get("WEAVE_PASSWORD", "nest-egg123")
88+
self.password = os.environ.get("WEAVE_PASSWORD")
8989

9090
self.initial_device_index = int(os.environ.get("INITIAL_DEVICE_INDEX", "1"))
9191

0 commit comments

Comments
 (0)