Skip to content
This repository was archived by the owner on Dec 20, 2023. It is now read-only.

Commit 2180d04

Browse files
committed
Address -Woverloaded-virtual warnings.
1 parent 9726ae3 commit 2180d04

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/test-apps/MockDMPublisher.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/*
22
*
3+
* Copyright (c) 2018 Google LLC.
34
* Copyright (c) 2016-2017 Nest Labs, Inc.
45
* All rights reserved.
56
*
@@ -34,7 +35,8 @@
3435
* table.
3536
*/
3637

37-
class MockDMPublisher : public nl::Weave::Profiles::DataManagement::DMPublisher
38+
class MockDMPublisher __FINAL :
39+
public nl::Weave::Profiles::DataManagement::DMPublisher
3840
{
3941
public:
4042
/*
@@ -46,7 +48,9 @@ class MockDMPublisher : public nl::Weave::Profiles::DataManagement::DMPublisher
4648

4749
WEAVE_ERROR UpdateIndication(ExchangeContext *aResponseCtx, ReferencedTLVData &aDataList);
4850

49-
void IncompleteIndication(const uint64_t &aPeerNodeId, StatusReport &aReport);
51+
virtual void IncompleteIndication(const uint64_t &aPeerNodeId, StatusReport &aReport);
52+
53+
using DMPublisher::IncompleteIndication;
5054

5155
#if WEAVE_CONFIG_WDM_ALLOW_PUBLISHER_SUBSCRIPTION
5256

src/test-apps/wdmtest.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/*
22
*
3+
* Copyright (c) 2018 Google LLC.
34
* Copyright (c) 2013-2017 Nest Labs, Inc.
45
* All rights reserved.
56
*
@@ -274,7 +275,7 @@ ReferencedTLVData DataList;
274275
* a sub-class of the WDM client and supply the relevant methods as follows.
275276
*/
276277

277-
class WDMTestClient :
278+
class WDMTestClient __FINAL :
278279
public DMClient
279280
{
280281
WEAVE_ERROR ViewConfirm(const uint64_t &aResponderId, StatusReport &aStatus, uint16_t aTxnId)
@@ -510,10 +511,13 @@ class WDMTestClient :
510511
return err;
511512
}
512513

513-
void IncompleteIndication(const uint64_t &aPeerNodeId, StatusReport &aReport)
514+
virtual void IncompleteIndication(const uint64_t &aPeerNodeId, StatusReport &aReport)
514515
{
516+
return;
515517
}
516518

519+
using DMClient::IncompleteIndication;
520+
517521
};
518522

519523
int main(int argc, char *argv[])

0 commit comments

Comments
 (0)