Merge pull request #626 from openweave/bug/fix_wdm_client_leak

robszewczyk · web-flow · commit 9befe6015620 · 2020-10-20T09:02:15.000-07:00
Fix the typo and leak in mpPublisherPathList
diff --git a/src/device-manager/WeaveDataManagementClient.cpp b/src/device-manager/WeaveDataManagementClient.cpp
@@ -970,7 +970,7 @@ void WdmClient::ClientEventCallback(void * const aAppState, SubscriptionClient::
             }
             WeaveLogDetail(DataManagement, "prepare to subscribe %d trait data sink", traitListLen);
 
-            if (pWdmClient->mpPublisherPathList == NULL)
+            if (pWdmClient->mpPublisherPathList != NULL)
             {
                 delete[] pWdmClient->mpPublisherPathList;
             }

Original file line number	Diff line number	Diff line change
`@@ -970,7 +970,7 @@ void WdmClient::ClientEventCallback(void * const aAppState, SubscriptionClient::`
`970`	`970`	`}`
`971`	`971`	`WeaveLogDetail(DataManagement, "prepare to subscribe %d trait data sink", traitListLen);`
`972`	`972`
`973`		`- if (pWdmClient->mpPublisherPathList == NULL)`
	`973`	`+ if (pWdmClient->mpPublisherPathList != NULL)`
`974`	`974`	`{`
`975`	`975`	`delete[] pWdmClient->mpPublisherPathList;`
`976`	`976`	`}`