Fix Objective C warnings

Fixed the following warnings:

* conflicting return type in implementation of 'setNodeId:': 'void *' vs 'void'
* extra tokens at end of #endif directive
* unannotated fall-through between switch labels
* designated initializer should only invoke a designated initializer on 'super'
* convenience initializer should not invoke an initializer on 'super'
* hiding of overloaded virtual functions

Author: robszewczyk

src/device-manager/WeaveDataManagementClient.h

@@ -81,7 +81,8 @@ typedef WEAVE_ERROR (*GetDataHandleFunct)(void * apContext, const TraitCatalogBa
 class NL_DLL_EXPORT GenericTraitUpdatableDataSink : public nl::Weave::Profiles::DataManagement::TraitUpdatableDataSink
 {
     friend class WdmClient;
-
+    using nl::Weave::Profiles::DataManagement_Current::TraitDataSink::SetData;
+    using nl::Weave::Profiles::DataManagement_Current::TraitUpdatableDataSink::GetData;
 private:
     GenericTraitUpdatableDataSink(const nl::Weave::Profiles::DataManagement::TraitSchemaEngine * aEngine, WdmClient * apWdmClient);
     ~GenericTraitUpdatableDataSink(void);

src/device-manager/cocoa/NLGenericTraitUpdatableDataSink_Protected.h

@@ -42,4 +42,4 @@
 - (void)close;
 
 @end
-#endif WEAVE_CONFIG_DATA_MANAGEMENT_CLIENT_EXPERIMENTAL
+#endif // WEAVE_CONFIG_DATA_MANAGEMENT_CLIENT_EXPERIMENTAL

src/device-manager/cocoa/NLNetworkInfo.h

@@ -60,7 +60,7 @@ extern const int NLThreadChannel_NotSpecified;
 @property (nonatomic, strong) NSData * ThreadPSKc; // The Thread pre-shared key commissioner, or NULL if not specified.
 
 
-- (instancetype)init NS_DESIGNATED_INITIALIZER;
+- (instancetype)init;
 
 - (id)initWithWiFiSSID:(NSString *)ssid wifiKey:(NSData *)wifiKey securityType:(NLWiFiSecurityType)securityType;
 

src/device-manager/cocoa/NLResourceIdentifier.h

@@ -29,6 +29,6 @@
 @property (nonatomic) int32_t ResourceType;
 @property (nonatomic) uint64_t ResourceId;
 
-- (instancetype)init NS_DESIGNATED_INITIALIZER;
-- (instancetype)initWithType:(int32_t)type id:(uint64_t)idValue;
+- (instancetype)init;
+- (instancetype)initWithType:(int32_t)type id:(uint64_t)idValue NS_DESIGNATED_INITIALIZER;
 @end

src/device-manager/cocoa/NLWdmClient.h

@@ -57,7 +57,7 @@ typedef void (^WdmClientFailureBlock)(id owner, NSError * error);
  * @param nodeId Weave node ID
  *
  */
-- (void *)setNodeId:(uint64_t)nodeId;
+- (void)setNodeId:(uint64_t)nodeId;
 
 /**
  * Create the new data newDataSink

src/device-manager/cocoa/NLWdmClient.mm

@@ -80,6 +80,7 @@ void bindingEventCallback(void * const apAppState, const nl::Weave::Binding::Eve
     case nl::Weave::Binding::kEvent_DefaultCheck:
         WDM_LOG_DEBUG(@"kEvent_DefaultCheck");
         // fall through
+        OS_FALLTHROUGH;
     default:
         nl::Weave::Binding::DefaultEventHandler(apAppState, aEvent, aInParam, aOutParam);
     }

src/device-manager/cocoa/NLWeaveStack.mm

@@ -477,10 +477,10 @@ - (NLWeaveDeviceManager *)createDeviceManager:(NSString *)name appCallbackQueue:
     WDM_LOG_METHOD_SIG();
 
     _mDeviceMgr = [[NLWeaveDeviceManager alloc] init:name
-                                                     weaveWorkQueue:_mWorkQueue
-                                                   appCallbackQueue:appCallbackQueue
-                                                        exchangeMgr:&_mExchangeMgr
-                                                        securityMgr:&_mSecurityMgr];
+                                      weaveWorkQueue:_mWorkQueue
+                                    appCallbackQueue:appCallbackQueue
+                                         exchangeMgr:&_mExchangeMgr
+                                         securityMgr:&_mSecurityMgr];
     if (nil == _mDeviceMgr) {
         WDM_LOG_ERROR(@"Cannot create new NLWeaveDeviceManager\n");
     }
@@ -492,12 +492,12 @@ - (NLWdmClient *)createWdmClient:(NSString *)name appCallbackQueue:(dispatch_que
 {
     WDM_LOG_METHOD_SIG();
 
-    NLWdmClient * _mWdmClient = [[NLWdmClient alloc] init:name
-                                           weaveWorkQueue:_mWorkQueue
-                                         appCallbackQueue:appCallbackQueue
-                                              exchangeMgr:&_mExchangeMgr
-                                             messageLayer:&_mMessageLayer
-                                     nlWeaveDeviceManager:_mDeviceMgr];
+    _mWdmClient = [[NLWdmClient alloc] init:name
+                             weaveWorkQueue:_mWorkQueue
+                           appCallbackQueue:appCallbackQueue
+                                exchangeMgr:&_mExchangeMgr
+                               messageLayer:&_mMessageLayer
+                       nlWeaveDeviceManager:_mDeviceMgr];
     if (nil == _mWdmClient) {
         WDM_LOG_ERROR(@"Cannot create new NLWdmClient\n");
     }