Merge pull request #37 from drgrice1/no-default-auto-operators

Remove all of the default autoOperatorNames.

Author: Alex-Jordan

package-lock.json

@@ -1,7 +1,7 @@
 {
 	"name": "@openwebwork/mathquill",
 	"description": "Easily type math in your webapp",
-	"version": "0.11.0-beta.4",
+	"version": "0.11.0-beta.5",
 	"license": "MPL-2.0",
 	"repository": {
 		"type": "git",

package.json

@@ -1,6 +1,6 @@
 // Symbols for Basic Mathematics
 
-import { type Direction, noop, bindMixin, LatexCmds, CharCmds } from 'src/constants';
+import { type Direction, noop, bindMixin, LatexCmds, CharCmds, BuiltInOpNames } from 'src/constants';
 import { Options } from 'src/options';
 import type { Cursor } from 'src/cursor';
 import { Parser } from 'services/parser.util';
@@ -40,10 +40,8 @@ class OperatorName extends Symbol {
 	}
 }
 
-for (const fn in new Options().autoOperatorNames) {
-	if (fn !== '_maxLength') {
-		LatexCmds[fn] = OperatorName;
-	}
+for (const fn in BuiltInOpNames) {
+	LatexCmds[fn] = OperatorName;
 }
 
 LatexCmds.operatorname = class extends MathCommand {

src/commands/math/basicSymbols.ts

@@ -129,39 +129,7 @@ export class Options {
 	}
 
 	// The set of operator names that MathQuill auto-unitalicizes.
-	static #autoOperatorNames: NamesWLength = (() => {
-		const ops: NamesWLength = { _maxLength: 9 };
-
-		// Standard operators
-		for (const op of [
-			'arg',
-			'det',
-			'dim',
-			'gcd',
-			'hom',
-			'ker',
-			'lg',
-			'lim',
-			'max',
-			'min',
-			'sup',
-			'limsup',
-			'liminf',
-			'injlim',
-			'projlim',
-			'Pr'
-		]) {
-			ops[op] = 1;
-		}
-
-		// compat with some of the nonstandard LaTeX exported by MathQuill
-		// before #247. None of these are real LaTeX commands so, seems safe
-		for (const op of ['gcf', 'hcf', 'lcm', 'proj', 'span']) {
-			ops[op] = 1;
-		}
-
-		return ops;
-	})();
+	static #autoOperatorNames: NamesWLength = { _maxLength: 0 };
 	#_autoOperatorNames?: NamesWLength;
 	get autoOperatorNames(): NamesWLength {
 		return this.#_autoOperatorNames ?? Options.#autoOperatorNames;

src/options.ts

@@ -65,8 +65,10 @@ suite('typing with auto-replaces', function () {
 		});
 
 		test('auto-operator names', function () {
+			mq.options.addAutoOperatorNames('ker');
 			mq.typedText('\\ker^2');
 			assertLatex('\\ker^2');
+			mq.options.removeAutoOperatorNames('ker');
 		});
 
 		test('nonexistent LaTeX command', function () {