Skip to content

Commit 0b4f1c0

Browse files
committed
Properly scope the .sortable-ghost style for the problem set detail page.
Currently that style is defined in the `system.scss` and is not scoped. As a result it applies to most content generator pages of webwork2. In particular it applies to problem pages, and thus it affects draggable proof problems which use the same sortablejs library with that same css class. Note that a related pull request to PG will change the styles for drag and drop problems and this conflicts with that. This is probably already a problem because the opacity of 0.5 does make the drag and drop elements in problems lack sufficient contrast. Although it only occurs during a mouse drag and in that situation perhaps that contrast is not necessary. Still I think there is a better way to do this for problems. On a related note to the PG pull request, perhaps at some point keyboard support should be added for reorganizing problems on the problem set detail page.
1 parent 983c1c6 commit 0b4f1c0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

htdocs/js/System/system.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -942,17 +942,17 @@ input.changed[type='text'] {
942942
}
943943
}
944944

945-
.sortable-ghost {
946-
opacity: 0.5;
947-
}
948-
949945
#psd_list {
950946
padding-left: 0;
951947
padding-bottom: 0.25rem;
952948
margin-bottom: 0;
953949

954950
.psd_list_item {
955951
list-style-type: none;
952+
953+
&.sortable-ghost {
954+
opacity: 0.5;
955+
}
956956
}
957957

958958
&:not(.disable_renumber) .pdr_handle {

0 commit comments

Comments
 (0)