From d62fe457aa5a2f4daf55b0335a2c2d6644d3eb45 Mon Sep 17 00:00:00 2001 From: Varadraj75 Date: Fri, 30 Jan 2026 10:07:57 +0530 Subject: [PATCH 1/4] [qa] Fix missing newline at end of files --- pyproject.toml | 9 +++++++++ run-qa-checks | 6 ++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 6db0eb03..6e0d66f7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,2 +1,11 @@ [tool.docstrfmt] extend_exclude = ["**/*.py"] + +[tool.flake8] +exclude = [ + ".venv", + "venv", + "__pycache__", + ".git", +] + \ No newline at end of file diff --git a/run-qa-checks b/run-qa-checks index 65eeeddc..88d416b4 100755 --- a/run-qa-checks +++ b/run-qa-checks @@ -1,7 +1,5 @@ #!/bin/bash set -e -openwisp-qa-check --skip-isort \ - --skip-flake8 \ - --skip-black \ - --skip-checkmigrations +openwisp-qa-check + \ No newline at end of file From 67ee59debae06663cf801e195d48879e02a18ad9 Mon Sep 17 00:00:00 2001 From: Varadraj75 Date: Fri, 30 Jan 2026 10:09:20 +0530 Subject: [PATCH 2/4] [qa] Format Python scripts with openwisp-qa-format --- files/generate_django_secret_key.py | 4 ++-- templates/load_initial_data.py | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/files/generate_django_secret_key.py b/files/generate_django_secret_key.py index c3de29ce..b7ece94e 100755 --- a/files/generate_django_secret_key.py +++ b/files/generate_django_secret_key.py @@ -2,5 +2,5 @@ # This script will generate a random 50-character string suitable for use as a SECRET_KEY. import secrets -charset = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789!@#$%^&*(-_=+)' -print(''.join(secrets.choice(charset) for _ in range(50))) +charset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789!@#$%^&*(-_=+)" +print("".join(secrets.choice(charset) for _ in range(50))) diff --git a/templates/load_initial_data.py b/templates/load_initial_data.py index 6428d267..5079b83a 100644 --- a/templates/load_initial_data.py +++ b/templates/load_initial_data.py @@ -6,6 +6,7 @@ - Adds a default access credential and updates or creates default template to use the same """ + import os import django From 3a6dd5d97a05966ac9d76592ab554b2e86f29279 Mon Sep 17 00:00:00 2001 From: Varadraj75 Date: Fri, 30 Jan 2026 10:10:31 +0530 Subject: [PATCH 3/4] [qa] Exclude Jinja templates from flake8 checks --- .flake8 | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .flake8 diff --git a/.flake8 b/.flake8 new file mode 100644 index 00000000..4b54ce4d --- /dev/null +++ b/.flake8 @@ -0,0 +1,11 @@ +[flake8] +exclude = + .venv + .venv/* + **/.venv/* + venv + venv/* + **/venv/* + .git + __pycache__ + templates/** From 1b91ec768931071971130f497b6073f837ad273a Mon Sep 17 00:00:00 2001 From: Varadraj75 Date: Fri, 30 Jan 2026 10:57:51 +0530 Subject: [PATCH 4/4] [qa] Fix missing newline at EOF for QA checks --- pyproject.toml | 1 - run-qa-checks | 1 - 2 files changed, 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 6e0d66f7..c6e85b44 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -8,4 +8,3 @@ exclude = [ "__pycache__", ".git", ] - \ No newline at end of file diff --git a/run-qa-checks b/run-qa-checks index 88d416b4..3def3687 100755 --- a/run-qa-checks +++ b/run-qa-checks @@ -2,4 +2,3 @@ set -e openwisp-qa-check - \ No newline at end of file