Skip to content

Commit f60f251

Browse files
committed
[docker-compose] Address linter and code review feedback #554
- Move DOCKER_TAG before EMAIL_DJANGO_DEFAULT in .env for alphabetical ordering - Add blank line at end of .env file - Add fallback to DOCKER_TAG in Makefile to handle unset/empty cases
1 parent 89e27f0 commit f60f251

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.env

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ API_DOMAIN=api.openwisp.org
88
SSH_PRIVATE_KEY_PATH=/home/openwisp/.ssh/id_ed25519
99
SSH_PUBLIC_KEY_PATH=/home/openwisp/.ssh/id_ed25519.pub
1010
VPN_DOMAIN=openvpn.openwisp.org
11+
DOCKER_TAG=25.10.0
1112
EMAIL_DJANGO_DEFAULT=example@example.org
1213
DB_USER=admin
1314
DB_PASS=admin
@@ -63,4 +64,3 @@ CELERY_SERVICE_NETWORK_MODE=service:openvpn
6364
METRIC_COLLECTION=True
6465
# collectstatic
6566
COLLECTSTATIC_WHEN_DEPS_CHANGE=true
66-
DOCKER_TAG=latest

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ pull:
2323
'openwisp-freeradius' 'openwisp-nginx' 'openwisp-openvpn' 'openwisp-postfix' \
2424
'openwisp-websocket' ; do \
2525
docker pull --quiet $(USER)/$${image}:$(TAG); \
26-
docker tag $(USER)/$${image}:$(TAG) openwisp/$${image}:$${DOCKER_TAG}; \
26+
docker tag $(USER)/$${image}:$(TAG) openwisp/$${image}:$${DOCKER_TAG:-latest}; \
2727
done
2828

2929
# Build

0 commit comments

Comments
 (0)