[fix] Fix Device.organization.RelatedObjectDoesNotExist error and improve test

Author: Srinath0916

.github/workflows/ci.yml

@@ -94,8 +94,13 @@ jobs:
           GECKO_LOG: 1
 
       - name: Show gecko web driver log on failures
-        if: ${{ failure() }}
-        run: cat geckodriver.log
+        if: ${{ failure() && steps.deps.conclusion == 'success' }}
+        run: |
+          if [ -f geckodriver.log ]; then
+            cat geckodriver.log
+          else
+            echo "geckodriver.log not found"
+          fi
 
       - name: Upload Coverage
         if: ${{ success() }}

openwisp_controller/config/base/config.py

@@ -415,7 +415,9 @@ def clean_templates_org(cls, action, instance, pk_set, raw_data=None, **kwargs):
             pk_list = [template.pk for template in templates]
             templates = template_model.objects.filter(pk__in=pk_list)
         # looking for invalid templates
-        organization = raw_data.get("organization", instance.device.organization)
+        organization = raw_data.get("organization") or getattr(
+            instance.device, "organization", None
+        )
         invalids = (
             templates.exclude(organization=organization)
             .exclude(organization=None)

openwisp_controller/config/tests/test_admin.py

@@ -2281,18 +2281,20 @@ def test_templates_fetch_queries_10(self):
 
     def test_empty_device_form_with_config_inline(self):
         """
-        Test for issue #1057: MultiValueDictKeyError when submitting
-        empty device form with configuration inline added
+        Ensures submitting device form with missing required fields
+        and configuration inline shows validation errors instead of
+        raising an exception
         """
         org = self._get_org()
+        template = self._create_template(organization=org)
         path = reverse(f"admin:{self.app_label}_device_add")
-        # Submit empty form with config inline
+        # Submit form without required device fields but with config inline
+        # This reproduces the scenario where user clicks "Add another Configuration"
+        # and submits without filling device details
         params = {
-            "name": "",
-            "mac_address": "",
-            "organization": "",
+            "organization": str(org.pk),
             "config-0-backend": "netjsonconfig.OpenWrt",
-            "config-0-templates": "",
+            "config-0-templates": str(template.pk),
             "config-0-config": json.dumps({}),
             "config-0-context": "",
             "config-TOTAL_FORMS": 1,