[fix] Fixed the deativation logic

Author: pandafy

openwisp_controller/config/base/config.py

@@ -639,7 +639,7 @@ def update_status_if_checksum_changed(
             bool: True if the checksum changed and an update was applied,
             False otherwise.
         """
-        checksum_changed = self._should_update_status_based_on_checksum()
+        checksum_changed = self._has_configuration_checksum_changed()
         if checksum_changed:
             self.checksum_db = self.checksum
             if self.status != "modified":
@@ -649,18 +649,12 @@ def update_status_if_checksum_changed(
                     extra_update_fields=["checksum_db"],
                 )
             else:
-                # Instead of calling the "save()" method, which would
-                # trigger various signals and checks, we directly update
-                # the "checksum_db" field in the database.
-                self._meta.model.objects.filter(pk=self.pk).update(
-                    checksum_db=self.checksum_db
-                )
+                self._update_checksum_db(new_checksum=self.checksum_db)
         return checksum_changed
 
-    def _should_update_status_based_on_checksum(self):
+    def _has_configuration_checksum_changed(self):
         """
-        Determines whether the config status should be updated based on
-        checksum comparison.
+        Determines whether the config checksum has changed
 
         Returns True if:
         - No checksum_db exists (first time)
@@ -675,6 +669,16 @@ def _should_update_status_based_on_checksum(self):
         self._invalidate_backend_instance_cache()
         return self.checksum_db != self.checksum
 
+    def _update_checksum_db(self, new_checksum=None):
+        """
+        Updates checksum_db field in the database
+
+        It does not call save() to avoid sending signals
+        and updating other fields.
+        """
+        new_checksum = new_checksum or self.checksum
+        self._meta.model.objects.filter(pk=self.pk).update(checksum_db=new_checksum)
+
     def _send_config_modified_signal(self, action):
         """
         Emits ``config_modified`` signal.
@@ -780,12 +784,20 @@ def deactivate(self):
         """
         # Invalidate cached property before checking checksum.
         self._invalidate_backend_instance_cache()
-        old_checksum = self.checksum
+        old_checksum = self.checksum_db
+        # Don't alter the order of the following steps.
+        # We need to set the status to deactivating before clearing the templates
+        # otherwise, the "enforce_required_templates" and "add_default_templates"
+        # methods would re-add required/default templates.
+        # The "templates_changed" receiver skips post_clear action. Thus,
+        # we need to update the checksum_db field manually.
         self.config = {}
-        self.set_status_deactivating()
+        self.set_status_deactivating(save=False)
         self.templates.clear()
-        del self.backend_instance
-        if old_checksum == self.checksum:
+        self._invalidate_backend_instance_cache()
+        self.checksum_db = self.checksum
+        self.save()
+        if old_checksum == self.checksum_db:
             # Accelerate deactivation if the configuration remains
             # unchanged (i.e. empty configuration)
             self.set_status_deactivated()

openwisp_controller/config/migrations/0061_config_checksum_db.py

@@ -10,17 +10,14 @@ def populate_checksum_db(apps, schema_editor):
     for existing Config objects.
     """
     Config = load_model("config", "Config")
-    batch = []
-    batch_size = 500
-    qs = Config.objects.filter(checksum_db__isnull=True).iterator()
+    qs = (
+        Config.objects.prefetch_related("vpnclient_set", "templates")
+        .select_related("device", "device__organization__config_settings")
+        .filter(checksum_db__isnull=True)
+        .iterator(chunk_size=100)
+    )
     for config in qs:
-        config.checksum_db = config.checksum
-        batch.append(config)
-        if len(batch) >= batch_size:
-            Config.objects.bulk_update(batch, ["checksum_db"])
-            batch = []
-    if batch:
-        Config.objects.bulk_update(batch, ["checksum_db"])
+        config.update_status_if_checksum_changed()
 
 
 class Migration(migrations.Migration):

openwisp_controller/config/tests/test_controller.py

@@ -1412,7 +1412,7 @@ def test_ip_fields_not_duplicated(self):
             )
         # triggers more queries because devices with conflicting addresses
         # need to be updated, luckily it does not happen often
-        with self.assertNumQueries(9):
+        with self.assertNumQueries(8):
             self.client.get(
                 reverse("controller:device_checksum", args=[c2.device.pk]),
                 {"key": c2.device.key, "management_ip": "192.168.1.99"},