[tests] Added assertion test for device template queries

Added a test to assert the queries executed during templates
fetch on device change page. Previous count of this fetch
combined with `get_relevant_templates` was 26 due to
template fetch query being duplicated. With new changes
the count is down to 24.

Signed-off-by: DragnEmperor <[email protected]>

Author: DragnEmperor

openwisp_controller/config/tests/test_admin.py

@@ -4,6 +4,7 @@
 from unittest.mock import patch
 from uuid import uuid4
 
+import django
 from django.contrib.admin.models import LogEntry
 from django.contrib.auth import get_user_model
 from django.core.exceptions import ValidationError
@@ -2018,6 +2019,41 @@ def test_vpn_template_switch(self):
             )
             self.assertEqual(config.vpnclient_set.count(), 1)
 
+    # helper for asserting queries executed during template fetch for a device
+    def _verify_template_queries(self, config, count):
+        path = reverse(f'admin:{self.app_label}_device_change', args=[config.device.pk])
+        for i in range(count):
+            self._create_template(name=f'template-{i}')
+        expected_count = 24
+        if django.VERSION < (5, 2):
+            # In django version < 5.2, there is an extra SAVEPOINT query
+            # leading to extra RELEASE SAVEPOINT query, thus 2 extra queries
+            expected_count += 2
+        with self.assertNumQueries(expected_count):
+            # contains 22 queries for fetching normal device data
+            response = self.client.get(path)
+            # contains 2 queries, 1 for fetching organization
+            # and 1 for fetching templates
+            response = self.client.get(
+                reverse(
+                    'admin:get_relevant_templates', args=[config.device.organization.pk]
+                )
+            )
+            self.assertEqual(response.status_code, 200)
+
+    # ensuring queries are consistent for different number of templates
+    def test_templates_fetch_queries_1(self):
+        config = self._create_config(organization=self._get_org())
+        self._verify_template_queries(config, 1)
+
+    def test_templates_fetch_queries_5(self):
+        config = self._create_config(organization=self._get_org())
+        self._verify_template_queries(config, 1)
+
+    def test_templates_fetch_queries_10(self):
+        config = self._create_config(organization=self._get_org())
+        self._verify_template_queries(config, 1)
+
 
 class TestTransactionAdmin(
     CreateConfigTemplateMixin,