[tests] Added new test for DeviceChecksumView, checks for WHOIS model

Signed-off-by: DragnEmperor <[email protected]>

Author: DragnEmperor

openwisp_controller/config/base/whois.py

@@ -2,6 +2,7 @@
 
 from django.core.cache import cache
 from django.core.exceptions import ValidationError
+from django.core.validators import MaxValueValidator, MinValueValidator
 from django.db import models, transaction
 from django.utils.translation import gettext_lazy as _
 from jsonfield import JSONField
@@ -55,11 +56,13 @@ class AbstractWHOISInfo(TimeStampedEditableModel):
         null=True,
         blank=True,
         help_text=_("Latitude"),
+        validators=[MinValueValidator(-90.0), MaxValueValidator(90.0)],
     )
     longitude = models.FloatField(
         null=True,
         blank=True,
         help_text=_("Longitude"),
+        validators=[MinValueValidator(-180.0), MaxValueValidator(180.0)],
     )
 
     class Meta:

openwisp_controller/config/migrations/0062_organizationconfigsettings_approximate_location_enabled_and_more.py

@@ -1,5 +1,6 @@
 # Generated by Django 5.2.1 on 2025-07-10 18:09
 
+import django.core.validators
 from django.db import migrations, models
 
 import openwisp_utils.fields
@@ -27,11 +28,27 @@ class Migration(migrations.Migration):
         migrations.AddField(
             model_name="whoisinfo",
             name="latitude",
-            field=models.FloatField(blank=True, help_text="Latitude", null=True),
+            field=models.FloatField(
+                blank=True,
+                help_text="Latitude",
+                null=True,
+                validators=[
+                    django.core.validators.MinValueValidator(-90.0),
+                    django.core.validators.MaxValueValidator(90.0),
+                ],
+            ),
         ),
         migrations.AddField(
             model_name="whoisinfo",
             name="longitude",
-            field=models.FloatField(blank=True, help_text="Longitude", null=True),
+            field=models.FloatField(
+                blank=True,
+                help_text="Longitude",
+                null=True,
+                validators=[
+                    django.core.validators.MinValueValidator(-180.0),
+                    django.core.validators.MaxValueValidator(180.0),
+                ],
+            ),
         ),
     ]

openwisp_controller/config/whois/test_whois.py

@@ -221,6 +221,37 @@ def test_whois_model_fields_validation(self):
         with self.assertRaises(ValidationError):
             self._create_whois_info(asn="InvalidASN")
 
+        # Common validation checks for latitude and longitude
+        latitudes = [
+            (100.0, "Ensure this value is less than or equal to 90.0."),
+            (-100.0, "Ensure this value is greater than or equal to -90.0."),
+        ]
+        for value, expected_msg in latitudes:
+            with self.assertRaises(ValidationError) as context_manager:
+                self._create_whois_info(latitude=value)
+            try:
+                self.assertEqual(
+                    context_manager.exception.message_dict["latitude"][0],
+                    expected_msg,
+                )
+            except AssertionError:
+                self.fail("ValidationError message not equal to expected message.")
+
+        longitudes = [
+            (200.0, "Ensure this value is less than or equal to 180.0."),
+            (-200.0, "Ensure this value is greater than or equal to -180.0."),
+        ]
+        for value, expected_msg in longitudes:
+            with self.assertRaises(ValidationError) as context_manager:
+                self._create_whois_info(longitude=value)
+            try:
+                self.assertEqual(
+                    context_manager.exception.message_dict["longitude"][0],
+                    expected_msg,
+                )
+            except AssertionError:
+                self.fail("ValidationError message not equal to expected message.")
+
 
 class TestWHOISTransaction(
     CreateWHOISMixin, WHOISTransactionMixin, TransactionTestCase
@@ -355,6 +386,8 @@ def _verify_whois_details(instance, ip_address):
                 instance.formatted_address,
                 "Mountain View, United States, North America, 94043",
             )
+            self.assertEqual(instance.latitude, 50)
+            self.assertEqual(instance.longitude, 150)
 
         # mocking the response from the geoip2 client
         mock_client.return_value.city.return_value = self._mocked_client_response()

openwisp_controller/config/whois/utils.py

@@ -60,6 +60,8 @@ def _create_whois_info(self, **kwargs):
             isp="Google LLC",
             timezone="America/Los_Angeles",
             cidr="172.217.22.0/24",
+            longitude=150.0,
+            latitude=50.0,
         )
 
         options.update(kwargs)
@@ -87,8 +89,8 @@ def _mocked_client_response():
         mock_response.traits.autonomous_system_number = 15169
         mock_response.traits.network = "172.217.22.0/24"
         mock_response.location.time_zone = "America/Los_Angeles"
-        mock_response.location.latitude = 2
-        mock_response.location.longitude = 23
+        mock_response.location.latitude = 50
+        mock_response.location.longitude = 150
         return mock_response
 
     def _task_called(self, mocked_task, task_name="WHOIS lookup"):
@@ -159,3 +161,18 @@ def _task_called(self, mocked_task, task_name="WHOIS lookup"):
             self.assertEqual(response.status_code, 200)
             mocked_task.assert_called()
         mocked_task.reset_mock()
+
+        with self.subTest(
+            f"{task_name} task not called via DeviceChecksumView when WHOIS is disabled"
+        ):
+            WHOISInfo.objects.all().delete()
+            org.config_settings.whois_enabled = False
+            org.config_settings.save(update_fields=["whois_enabled"])
+            response = self.client.get(
+                reverse("controller:device_checksum", args=[device.pk]),
+                {"key": device.key},
+                REMOTE_ADDR=device.last_ip,
+            )
+            self.assertEqual(response.status_code, 200)
+            mocked_task.assert_not_called()
+        mocked_task.reset_mock()

openwisp_controller/geo/approximate_location/__init__.py

@@ -26,7 +26,7 @@ class TestApproximateLocation(TestAdminMixin, TestCase):
         OPENWISP_CONTROLLER_WHOIS_GEOIP_ACCOUNT="test_account",
         OPENWISP_CONTROLLER_WHOIS_GEOIP_KEY="test_key",
     )
-    def test_whois_configuration_setting(self):
+    def test_approximate_location_configuration_setting(self):
         # reload app_settings to apply the overridden settings
         importlib.reload(config_app_settings)
         with self.subTest(
@@ -91,6 +91,9 @@ def test_approximate_location_task_called(
         with self.subTest(
             "Approximate location task called when last_ip has related WhoIsInfo"
         ):
+            device.organization.config_settings.whois_enabled = True
+            device.organization.config_settings.approximate_location_enabled = True
+            device.organization.config_settings.save()
             device.last_ip = "172.217.22.14"
             self._create_whois_info(ip_address=device.last_ip)
             device.save()
@@ -136,8 +139,8 @@ def _verify_location_details(device, mocked_response):
 
         with self.subTest("Test Fuzzy location updated when last ip is updated"):
             device.last_ip = "172.217.22.10"
-            mocked_response.location.latitude = 100
-            mocked_response.location.longitude = 200
+            mocked_response.location.latitude = 50
+            mocked_response.location.longitude = 150
             mocked_response.city.name = "New City"
             mock_client.return_value.city.return_value = mocked_response
             device.save()

openwisp_controller/geo/approximate_location/test_approximate_location.py

@@ -1,5 +1,6 @@
 # Generated by Django 5.2.1 on 2025-07-11 16:28
 
+import django.core.validators
 from django.db import migrations, models
 
 import openwisp_utils.fields
@@ -27,11 +28,27 @@ class Migration(migrations.Migration):
         migrations.AddField(
             model_name="whoisinfo",
             name="latitude",
-            field=models.FloatField(blank=True, help_text="Latitude", null=True),
+            field=models.FloatField(
+                blank=True,
+                help_text="Latitude",
+                null=True,
+                validators=[
+                    django.core.validators.MinValueValidator(-90.0),
+                    django.core.validators.MaxValueValidator(90.0),
+                ],
+            ),
         ),
         migrations.AddField(
             model_name="whoisinfo",
             name="longitude",
-            field=models.FloatField(blank=True, help_text="Longitude", null=True),
+            field=models.FloatField(
+                blank=True,
+                help_text="Longitude",
+                null=True,
+                validators=[
+                    django.core.validators.MinValueValidator(-180.0),
+                    django.core.validators.MaxValueValidator(180.0),
+                ],
+            ),
         ),
     ]