Skip to content

Commit 5f85ee0

Browse files
committed
[qa] Fixed QA
1 parent dcec087 commit 5f85ee0

File tree

3 files changed

+3
-13
lines changed

3 files changed

+3
-13
lines changed

openwisp_controller/config/apps.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
from .signals import (
2424
config_backend_changed,
2525
config_deactivated,
26-
config_deactivating,
27-
config_modified,
2826
device_group_changed,
2927
device_name_changed,
3028
group_templates_changed,

openwisp_controller/config/controller/views.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,6 @@ def invalidate_get_device_cache_on_config_deactivated(cls, instance, **kwargs):
190190
"""
191191
cls.invalidate_get_device_cache(instance=instance.device, **kwargs)
192192

193-
@classmethod
194-
def invalidate_checksum_cache(cls, instance, device, **kwargs):
195-
"""
196-
Called from signal receiver which performs cache invalidation
197-
"""
198-
instance.get_cached_checksum.invalidate(instance)
199-
logger.debug(f"invalidated checksum cache for device ID {device.pk}")
200-
201193

202194
class DeviceDownloadConfigView(GetDeviceView):
203195
"""

openwisp_controller/config/tests/test_config.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ def test_get_cached_checksum(self):
262262
self.assertEqual(c.get_cached_checksum(), c.checksum)
263263
mocked_debug.assert_called_once()
264264

265-
with self.subTest('cache invalidation works when config is deactivated'):
265+
with self.subTest("cache invalidation works when config is deactivated"):
266266
with patch.object(base_config_logger, "debug") as mocked_debug:
267267
old_checksum = c.checksum
268268
c.deactivate()
@@ -837,11 +837,11 @@ def test_config_modified_sent(self):
837837

838838
def test_check_changes_query(self):
839839
config = self._create_config(organization=self._get_org())
840-
with self.subTest('No changes made to the config object'):
840+
with self.subTest("No changes made to the config object"):
841841
with self.assertNumQueries(3):
842842
config._check_changes()
843843

844-
with self.subTest('Changes made to the config object'):
844+
with self.subTest("Changes made to the config object"):
845845
config.templates.add(self._create_template())
846846
config.config = {"general": {"description": "test"}}
847847
with self.assertNumQueries(4):

0 commit comments

Comments
 (0)