[fix] Restored disappeared download configuration button #259

Fixes #259

Author: NoumbissiValere

openwisp_controller/config/admin.py

@@ -90,10 +90,9 @@ def get_extra_context(self, pk=None):
         if pk:
             ctx['download_url'] = reverse('{0}_download'.format(prefix), args=[pk])
             try:
-                has_config = (
-                    self.model.__name__ == 'Device'
-                    and self.model.objects.get(pk=pk)._has_config()
-                )
+                has_config = True
+                if self.model.__name__ == 'Device':
+                    has_config = self.model.objects.get(pk=pk)._has_config()
             except (ObjectDoesNotExist, ValidationError):
                 raise Http404()
             else:

openwisp_controller/config/tests/test_admin.py

@@ -614,6 +614,12 @@ def test_download_template_config(self):
         response = self.client.get(path)
         self.assertEqual(response.get('content-type'), 'application/octet-stream')
 
+    def test_template_has_download_config(self):
+        t = Template.objects.first()
+        path = reverse(f'admin:{self.app_label}_template_change', args=[t.pk])
+        r = self.client.get(path)
+        self.assertContains(r, 'Download configuration')
+
     def test_preview_template(self):
         template = Template.objects.get(name='radio0')
         path = reverse(f'admin:{self.app_label}_template_preview')
@@ -759,6 +765,12 @@ def test_download_vpn_config(self):
         response = self.client.get(path)
         self.assertEqual(response.get('content-type'), 'application/octet-stream')
 
+    def test_vpn_has_download_config(self):
+        v = self._create_vpn()
+        path = reverse(f'admin:{self.app_label}_vpn_change', args=[v.pk])
+        r = self.client.get(path)
+        self.assertContains(r, 'Download configuration')
+
     def test_preview_vpn(self):
         v = self._create_vpn()
         path = reverse(f'admin:{self.app_label}_vpn_preview')
@@ -810,6 +822,14 @@ def test_error_if_download_config(self):
         )
         self.assertNotContains(res, 'Download configuration')
 
+    def test_device_has_download_config(self):
+        d = self._create_device()
+        t = Template.objects.first()
+        self._create_config(device=d, backend=t.backend, config=t.config)
+        path = reverse(f'admin:{self.app_label}_device_change', args=[d.pk])
+        r = self.client.get(path)
+        self.assertContains(r, 'Download configuration')
+
     def test_preview_device_with_context(self):
         path = reverse(f'admin:{self.app_label}_device_preview')
         config = json.dumps(