[fix] Fixed deletion of VPN Client certificate #611

- Deletion of VPN Client certificate raises 'ObjectDoesNotExist' exception.
- Wrapped post_delete signal in a try-except block.

Closes #611

Author: Aryamanz29

openwisp_controller/config/base/vpn.py

@@ -656,9 +656,11 @@ class method for ``post_delete`` signal
         # only invalidates, does not regenerate the cache
         # to avoid generating high load during bulk deletes
         instance.vpn._invalidate_peer_cache()
-
-        if instance.cert:
-            instance.cert.delete()
+        try:
+            if instance.cert:
+                instance.cert.delete()
+        except ObjectDoesNotExist:
+            pass
         try:
             if instance.ip:
                 instance.ip.delete()

openwisp_controller/config/tests/test_vpn.py

@@ -138,6 +138,19 @@ def test_vpn_client_auto_cert_deletes_cert(self):
         self.assertEqual(VpnClient.objects.filter(pk=vpnclient.pk).count(), 0)
         self.assertEqual(Cert.objects.filter(pk=cert_pk).count(), 0)
 
+    def test_vpn_client_cert_post_deletes_cert(self):
+        org = self._get_org()
+        vpn = self._create_vpn()
+        t = self._create_template(name='vpn-test', type='vpn', vpn=vpn, auto_cert=True)
+        c = self._create_config(organization=org)
+        c.templates.add(t)
+        vpnclient = c.vpnclient_set.first()
+        cert_pk = vpnclient.cert.pk
+        self.assertEqual(Cert.objects.filter(pk=cert_pk).count(), 1)
+        vpnclient.cert.delete()
+        self.assertEqual(VpnClient.objects.filter(pk=vpnclient.pk).count(), 0)
+        self.assertEqual(Cert.objects.filter(pk=cert_pk).count(), 0)
+
     def test_vpn_cert_and_ca_mismatch(self):
         ca = self._create_ca()
         different_ca = self._create_ca(common_name='different-ca')