[qa] Formatted code

Author: pandafy

openwisp_controller/config/migrations/__init__.py

@@ -25,10 +25,10 @@ def update_vpn_dhparam_length(apps, schema_editor):
 
 def assign_permissions_to_groups(apps, schema_editor):
     create_default_permissions(apps, schema_editor)
-    operators_and_admins_can_change = ['device', 'config', 'template']
-    operators_read_only_admins_manage = ['vpn']
-    manage_operations = ['add', 'change', 'view', 'delete']
-    Group = get_swapped_model(apps, 'openwisp_users', 'Group')
+    operators_and_admins_can_change = ["device", "config", "template"]
+    operators_read_only_admins_manage = ["vpn"]
+    manage_operations = ["add", "change", "view", "delete"]
+    Group = get_swapped_model(apps, "openwisp_users", "Group")
 
     try:
         admin = Group.objects.get(name="Administrator")

openwisp_controller/config/tests/test_admin.py

@@ -518,20 +518,20 @@ def test_org_admin_create_template_with_shared_vpn(self):
         vpn = self._create_vpn(organization=None)
         org = self._create_org()
         administrator = self._create_administrator(organizations=[org])
-        path = reverse(f'admin:{self.app_label}_template_add')
+        path = reverse(f"admin:{self.app_label}_template_add")
         payload = {
-            'organization': '',
-            'name': 'Test',
-            'type': 'vpn',
-            'vpn': str(vpn.id),
-            'backend': 'netjsonconfig.OpenWrt',
-            'config': '',
-            'default_values': '',
-            'tags': '',
+            "organization": "",
+            "name": "Test",
+            "type": "vpn",
+            "vpn": str(vpn.id),
+            "backend": "netjsonconfig.OpenWrt",
+            "config": "",
+            "default_values": "",
+            "tags": "",
         }
         self.assertEqual(Template.objects.count(), 2)
 
-        with self.subTest('Should not allow creating shared template'):
+        with self.subTest("Should not allow creating shared template"):
             self._test_org_admin_create_shareable_object(
                 path=path,
                 payload=payload,
@@ -540,8 +540,8 @@ def test_org_admin_create_template_with_shared_vpn(self):
                 user=administrator,
             )
 
-        with self.subTest('Should allow creating non-shared template'):
-            payload['organization'] = str(org.pk)
+        with self.subTest("Should allow creating non-shared template"):
+            payload["organization"] = str(org.pk)
             self._test_org_admin_create_shareable_object(
                 path=path,
                 payload=payload,
@@ -553,25 +553,25 @@ def test_org_admin_create_template_with_shared_vpn(self):
 
     def test_org_admin_view_shared_template(self):
         vpn = self._create_vpn(organization=None)
-        template = self._create_template(type='vpn', vpn=vpn)
+        template = self._create_template(type="vpn", vpn=vpn)
         self._test_org_admin_view_shareable_object(
-            path=reverse(f'admin:{self.app_label}_template_change', args=[template.pk]),
+            path=reverse(f"admin:{self.app_label}_template_change", args=[template.pk]),
         )
 
     def test_vpn_queryset(self):
         data = self._create_multitenancy_test_env(vpn=True)
         self._test_multitenant_admin(
-            url=reverse(f'admin:{self.app_label}_vpn_changelist'),
+            url=reverse(f"admin:{self.app_label}_vpn_changelist"),
             visible=[
-                data['org1'].name,
-                data['vpn1'].name,
-                data['vpn_shared'].name,
+                data["org1"].name,
+                data["vpn1"].name,
+                data["vpn_shared"].name,
             ],
             hidden=[
-                data['org2'].name,
-                data['inactive'],
-                data['vpn2'].name,
-                data['vpn_inactive'].name,
+                data["org2"].name,
+                data["inactive"],
+                data["vpn2"].name,
+                data["vpn_inactive"].name,
             ],
         )
 
@@ -620,23 +620,23 @@ def test_org_admin_create_shared_vpn(self):
         org = self._get_org()
         ca = self._create_ca(organization=org)
         self._test_org_admin_create_shareable_object(
-            path=reverse(f'admin:{self.app_label}_vpn_add'),
+            path=reverse(f"admin:{self.app_label}_vpn_add"),
             model=Vpn,
             payload={
-                'organization': '',
-                'name': 'Test',
-                'host': 'vpn1.test.com',
-                'key': 'vZFUV5FqYt4WW9nerc23BofQH51gHNNy',
-                'backend': 'openwisp_controller.vpn_backends.OpenVPN',
-                'ca': ca.pk,
-                'config': {
-                    'openvpn': [
+                "organization": "",
+                "name": "Test",
+                "host": "vpn1.test.com",
+                "key": "vZFUV5FqYt4WW9nerc23BofQH51gHNNy",
+                "backend": "openwisp_controller.vpn_backends.OpenVPN",
+                "ca": ca.pk,
+                "config": {
+                    "openvpn": [
                         {
-                            'server_bridge': '10.8.0.0 255.255.255.0',
-                            'name': 'tun0',
-                            'mode': 'server',
-                            'proto': 'udp',
-                            'dev': 'tun0',
+                            "server_bridge": "10.8.0.0 255.255.255.0",
+                            "name": "tun0",
+                            "mode": "server",
+                            "proto": "udp",
+                            "dev": "tun0",
                         }
                     ]
                 },
@@ -646,7 +646,7 @@ def test_org_admin_create_shared_vpn(self):
     def test_org_admin_view_shared_vpn(self):
         vpn = self._create_vpn(organization=None)
         self._test_org_admin_view_shareable_object(
-            path=reverse(f'admin:{self.app_label}_vpn_change', args=[vpn.pk]),
+            path=reverse(f"admin:{self.app_label}_vpn_change", args=[vpn.pk]),
         )
 
     def test_device_template_filter(self):

openwisp_controller/config/tests/test_api.py

@@ -652,10 +652,10 @@ def test_operator_access_shared_template(self):
         token = self._obtain_auth_token(test_user)
         self._create_template(organization=None)
         self._test_org_user_access_shared_object(
-            listview_name='config_api:template_list',
-            detailview_name='config_api:template_detail',
-            create_payload={'name': 'test', 'organization': ''},
-            update_payload={'name': 'updated-test'},
+            listview_name="config_api:template_list",
+            detailview_name="config_api:template_detail",
+            create_payload={"name": "test", "organization": ""},
+            update_payload={"name": "updated-test"},
             expected_count=1,
             token=token,
         )
@@ -666,30 +666,30 @@ def test_org_admin_create_template_with_shared_vpn(self):
         create_payload = self._template_data
         create_payload.update(
             {
-                'organization': org.pk,
-                'type': 'vpn',
-                'vpn': vpn.pk,
+                "organization": org.pk,
+                "type": "vpn",
+                "vpn": vpn.pk,
             }
         )
         update_payload = create_payload.copy()
-        update_payload['name'] = 'updated-test'
+        update_payload["name"] = "updated-test"
         test_user = self._create_operator(organizations=[org])
         self._test_org_user_access_shared_object(
-            listview_name='config_api:template_list',
-            detailview_name='config_api:template_detail',
+            listview_name="config_api:template_list",
+            detailview_name="config_api:template_detail",
             create_payload=create_payload,
             update_payload=update_payload,
             expected_count=1,
             token=self._obtain_auth_token(test_user),
             expected_status_codes={
-                'create': 201,
-                'list': 200,
-                'retrieve': 200,
-                'update': 200,
-                'delete': 204,
-                'head': 200,
-                'option': 200,
-            }
+                "create": 201,
+                "list": 200,
+                "retrieve": 200,
+                "update": 200,
+                "delete": 204,
+                "head": 200,
+                "option": 200,
+            },
         )
 
     def test_template_create_with_empty_config(self):
@@ -854,45 +854,45 @@ def test_vpn_create_api(self):
 
     def test_org_admin_access_vpn_with_shared_objects(self):
         org = self._get_org()
-        shared_ca = self._create_ca(name='shared_ca', organization=None)
+        shared_ca = self._create_ca(name="shared_ca", organization=None)
         create_payload = self._vpn_data
         create_payload.update(
             {
-                'organization': org.pk,
-                'ca': shared_ca.pk,
+                "organization": org.pk,
+                "ca": shared_ca.pk,
             }
         )
         update_payload = create_payload.copy()
-        update_payload['name'] = 'updated-test-vpn'
+        update_payload["name"] = "updated-test-vpn"
         administrator = self._create_administrator(organizations=[org])
         self._test_access_shared_object(
-            listview_name='config_api:vpn_list',
-            detailview_name='config_api:vpn_detail',
+            listview_name="config_api:vpn_list",
+            detailview_name="config_api:vpn_detail",
             create_payload=create_payload,
             update_payload=update_payload,
             expected_count=1,
             expected_status_codes={
-                'create': 201,
-                'list': 200,
-                'retrieve': 200,
-                'update': 200,
-                'delete': 204,
-                'head': 200,
-                'option': 200,
+                "create": 201,
+                "list": 200,
+                "retrieve": 200,
+                "update": 200,
+                "delete": 204,
+                "head": 200,
+                "option": 200,
             },
             token=self._obtain_auth_token(administrator),
         )
 
     def test_org_admin_create_shared_vpn(self):
-        shared_ca = self._create_ca(name='shared_ca', organization=None)
+        shared_ca = self._create_ca(name="shared_ca", organization=None)
         data = self._vpn_data
-        data['ca'] = shared_ca.pk
+        data["ca"] = shared_ca.pk
         # API does not allow creating shared VPN by org admin,
         # therefore we create an object to test the detail view.
         self._create_vpn(organization=None, ca=shared_ca)
         self._test_org_user_access_shared_object(
-            listview_name='config_api:vpn_list',
-            detailview_name='config_api:vpn_detail',
+            listview_name="config_api:vpn_list",
+            detailview_name="config_api:vpn_detail",
             create_payload=data,
             expected_count=1,
         )

openwisp_controller/geo/migrations/__init__.py

@@ -5,9 +5,9 @@
 
 def assign_permissions_to_groups(apps, schema_editor):
     create_default_permissions(apps, schema_editor)
-    operators_and_admins_can_change = ['location', 'floorplan', 'devicelocation']
-    manage_operations = ['add', 'change', 'view', 'delete']
-    Group = get_swapped_model(apps, 'openwisp_users', 'Group')
+    operators_and_admins_can_change = ["location", "floorplan", "devicelocation"]
+    manage_operations = ["add", "change", "view", "delete"]
+    Group = get_swapped_model(apps, "openwisp_users", "Group")
 
     try:
         admin = Group.objects.get(name="Administrator")

openwisp_controller/pki/api/serializers.py

@@ -78,13 +78,13 @@ class Meta:
             # Setting the default to `serializers.empty` ensures DRF does not treat
             # these fields as both required and having a default value, avoiding
             # conflicts.
-            'organization': {'required': True, 'default': serializers.empty},
-            'common_name': {'default': '', 'required': False},
-            'key_length': {'initial': '2048'},
-            'digest': {'initial': 'sha256'},
-            'passphrase': {'write_only': True},
-            'validity_start': {'default': default_validity_start()},
-            'validity_end': {'default': default_ca_validity_end()},
+            "organization": {"required": True, "default": serializers.empty},
+            "common_name": {"default": "", "required": False},
+            "key_length": {"initial": "2048"},
+            "digest": {"initial": "sha256"},
+            "passphrase": {"write_only": True},
+            "validity_start": {"default": default_validity_start()},
+            "validity_end": {"default": default_ca_validity_end()},
         }