[tests] Updated tests for caching in estimate location

Signed-off-by: DragnEmperor <[email protected]>

Author: DragnEmperor

openwisp_controller/config/whois/service.py

@@ -143,8 +143,8 @@ def trigger_whois_lookup(self):
                     new_ip_address=new_ip,
                 )
             )
-        # `add_existing` is `True` to handle the case when WHOIS already exists
-        # as in that case WHOIS lookup is not triggered but we still need to
+        # To handle the case when WHOIS already exists as in that case
+        # WHOIS lookup is not triggered but we still need to
         # manage estimated locations.
         elif self._need_estimated_location_management(new_ip):
             transaction.on_commit(

openwisp_controller/config/whois/tests_utils.py

@@ -70,13 +70,14 @@ def _task_called(self, mocked_task, task_name="WHOIS lookup"):
         with self.subTest(
             f"{task_name} task called when last_ip is changed and is public"
         ):
-            with mock.patch("django.core.cache.cache.get") as mocked_get:
+            with mock.patch("django.core.cache.cache.get") as mocked_get, mock.patch(
+                "django.core.cache.cache.set"
+            ) as mocked_set:
                 device.last_ip = "172.217.22.10"
                 device.save()
                 mocked_task.assert_called()
-                # The cache `get` is called twice, once for `whois_enabled` and
-                # once for `estimated_location_enabled`
-                mocked_get.assert_called()
+                mocked_set.assert_not_called()
+                mocked_get.assert_called_once()
         mocked_task.reset_mock()
 
         with self.subTest(f"{task_name} task not called when last_ip is private"):

openwisp_controller/geo/estimated_location/test_estimated_location.py

@@ -135,13 +135,20 @@ def test_estimated_location_task_called(
         with self.subTest(
             "Estimated location task called when last_ip has related WhoIsInfo"
         ):
-            device.organization.config_settings.whois_enabled = True
-            device.organization.config_settings.estimated_location_enabled = True
-            device.organization.config_settings.save()
-            device.last_ip = "172.217.22.14"
-            self._create_whois_info(ip_address=device.last_ip)
-            device.save()
-            mocked_estimated_location_task.assert_called()
+            with mock.patch("django.core.cache.cache.get") as mocked_get, mock.patch(
+                "django.core.cache.cache.set"
+            ) as mocked_set:
+                device.organization.config_settings.whois_enabled = True
+                device.organization.config_settings.estimated_location_enabled = True
+                device.organization.config_settings.save()
+                device.last_ip = "172.217.22.14"
+                self._create_whois_info(ip_address=device.last_ip)
+                device.save()
+                mocked_set.assert_not_called()
+                # The cache `get` is called twice, once for `whois_enabled` and
+                # once for `estimated_location_enabled`
+                mocked_get.assert_called()
+                mocked_estimated_location_task.assert_called()
         mocked_estimated_location_task.reset_mock()
 
         with self.subTest(