[tests] Run selenium in non parallel mode on SQlite (drop postgres)

Author: nemesifier

.github/workflows/ci.yml

@@ -79,9 +79,9 @@ jobs:
           pip install -U -e .
           pip install ${{ matrix.django-version }}
 
-      - name: Start postgres and redis
+      - name: Start redis
         if: ${{ !cancelled() && steps.deps.conclusion == 'success' }}
-        run: docker compose up -d postgres redis
+        run: docker compose up -d redis
 
       - name: QA checks
         run: ./run-qa-checks

docker-compose.yml

@@ -17,12 +17,3 @@ services:
     ports:
       - "6379:6379"
     entrypoint: redis-server --appendonly yes
-
-  postgres:
-    image: postgis/postgis:17-3.5-alpine
-    environment:
-      POSTGRES_PASSWORD: openwisp2
-      POSTGRES_USER: openwisp2
-      POSTGRES_DB: openwisp2
-    ports:
-      - 5432:5432

docs/developer/installation.rst

@@ -37,11 +37,11 @@ Navigate into the cloned repository:
 
     cd openwisp-controller/
 
-Launch Redis and PostgreSQL:
+Launch Redis:
 
 .. code-block:: shell
 
-    docker compose up -d redis postgres
+    docker compose up -d redis
 
 Setup and activate a virtual-environment (we'll be using `virtualenv
 <https://pypi.org/project/virtualenv/>`_):
@@ -99,18 +99,6 @@ Run tests with (make sure you have the :ref:`selenium dependencies
 
     ./runtests
 
-Some tests, such as the Selenium UI tests, require a PostgreSQL database
-to run. If you don't have a PostgreSQL database running on your system,
-you can use :ref:`the Docker Compose configuration provided in this
-repository <controller_dev_docker>`. Once set up, you can run these
-specific tests as follows:
-
-.. code-block:: shell
-
-    # Run only specific selenium tests classes
-    cd tests/
-    DJANGO_SETTINGS_MODULE=openwisp2.postgresql_settings ./manage.py test openwisp_controller.config.tests.test_selenium.TestDeviceAdmin
-
 Run quality assurance tests with:
 
 .. code-block:: shell

runtests

@@ -1,13 +1,18 @@
 #!/bin/bash
 set -e
 
-# standard tests
-coverage run runtests.py --parallel \
+echo "Starting standard tests"
+coverage run runtests.py --parallel --exclude-tag=selenium_tests \
   || coverage run ./runtests.py
-# tests the extension capability
+
+echo "Starting standard tests"
+coverage run runtests.py --tag=selenium_tests --no-input --exclude-pytest
+
+echo "Starting tests for extensibility"
 SAMPLE_APP=1 coverage run ./runtests.py \
   --parallel --exclude-tag=selenium_tests \
   || SAMPLE_APP=1 coverage run ./runtests.py \
   --exclude-tag=selenium_tests
+
 coverage combine
 coverage xml

runtests.py

@@ -35,25 +35,22 @@ def run_tests(extra_args, settings_module, test_app):
     # Configure Django settings for test execution
     # (sets Celery to eager mode, configures in-memory channels layer, etc.)
     os.environ.setdefault("TESTING", "1")
-    base_args = sys.argv.copy()[1:]
+    args = sys.argv.copy()[1:]
+    exclude_pytest = "--exclude-pytest" in args
+    if exclude_pytest:
+        args.pop(args.index("--exclude-pytest"))
+    # normal tests vs SAMPLE_APP
     if not os.environ.get("SAMPLE_APP", False):
         test_app = "openwisp_controller"
         app_dir = "openwisp_controller/"
     else:
         test_app = "openwisp2"
         app_dir = "tests/openwisp2/"
-    # Run all tests except Selenium tests using SQLite
-    sqlite_args = ["--exclude-tag", "selenium_tests"] + base_args
-    run_tests(sqlite_args, "openwisp2.settings", test_app)
-
-    # Run Selenium tests using PostgreSQL
-    psql_args = [
-        "--tag",
-        "db_tests",
-        "--tag",
-        "selenium_tests",
-    ] + base_args
-    run_tests(psql_args, "openwisp2.postgresql_settings", test_app)
-
+    # Run Django tests
+    django_tests = run_tests(args, "openwisp2.settings", test_app)
     # Run pytest tests
-    sys.exit(pytest.main([app_dir]))
+    if not exclude_pytest:
+        # Used to test django-channels
+        sys.exit(pytest.main([app_dir]))
+    else:
+        sys.exit(django_tests)