[deps] Added support for Django >=5.1,<5.3 and Python >=3.12, 3.14 #987

- Dropped support for Python < 3.9
- Dropped support for Django < 4.2

Closes #987

Author: pandafy

openwisp_controller/connection/base/models.py

@@ -1,6 +1,7 @@
 import collections
 import logging
 
+import django
 import jsonschema
 from django.core.exceptions import ValidationError
 from django.db import models, transaction
@@ -24,6 +25,7 @@
     ORGANIZATION_COMMAND_SCHEMA,
     ORGANIZATION_ENABLED_COMMANDS,
     get_command_callable,
+    get_command_choices,
     get_command_schema,
 )
 from ..exceptions import NoWorkingDeviceConnectionError
@@ -408,7 +410,18 @@ class AbstractCommand(TimeStampedEditableModel):
     status = models.CharField(
         max_length=12, choices=STATUS_CHOICES, default=STATUS_CHOICES[0][0]
     )
-    type = models.CharField(max_length=16, choices=COMMAND_CHOICES)
+    type = models.CharField(
+        max_length=16,
+        choices=(
+            COMMAND_CHOICES
+            if django.VERSION < (5, 0)
+            # In Django 5.0+, choices are normalized at model definition,
+            # creating a static list of tuples that doesn't update when command
+            # are dynamically registered or unregistered. Using a callable
+            # ensures we always get the current choices from the registry.
+            else get_command_choices
+        ),
+    )
     input = JSONField(
         blank=True,
         null=True,

openwisp_controller/connection/commands.py

@@ -155,3 +155,10 @@ def _unregister_command_choice(command):
     ORGANIZATION_COMMAND_SCHEMA[org_id] = OrderedDict()
     for command in commands:
         ORGANIZATION_COMMAND_SCHEMA[org_id][command] = COMMANDS[command]['schema']
+
+
+def get_command_choices():
+    """
+    Returns the command choices.
+    """
+    return COMMAND_CHOICES

openwisp_controller/connection/migrations/0007_command.py

@@ -3,6 +3,7 @@
 import collections
 import uuid
 
+import django
 import django.db.migrations.operations.special
 import django.db.models.deletion
 import django.utils.timezone
@@ -11,7 +12,7 @@
 import swapper
 from django.db import migrations, models
 
-from ..commands import COMMAND_CHOICES
+from ..commands import COMMAND_CHOICES, get_command_choices
 from . import assign_command_permissions_to_groups
 
 
@@ -65,7 +66,9 @@ class Migration(migrations.Migration):
                 (
                     'type',
                     models.CharField(
-                        choices=COMMAND_CHOICES,
+                        choices=COMMAND_CHOICES
+                        if django.VERSION < (5, 0)
+                        else get_command_choices,
                         max_length=16,
                     ),
                 ),

openwisp_controller/connection/utils.py

@@ -2,5 +2,5 @@
 
 
 def get_connection_working_notification_target_url(obj, field, absolute_url=True):
-    url = _get_object_link(obj, field, absolute_url)
+    url = _get_object_link(obj._related_object(field), absolute_url)
     return f'{url}#deviceconnection_set-group'

openwisp_controller/geo/tests/test_admin_inline.py

@@ -78,3 +78,4 @@ def test_add_mobile(self):
 
 
 del TestConfigAdmin
+del BaseTestAdminInline

openwisp_controller/geo/tests/test_api.py

@@ -577,7 +577,7 @@ def test_change_location_type_to_outdoor_api(self):
         self._create_floorplan(location=l1)
         path = reverse('geo_api:detail_location', args=[l1.pk])
         data = {'type': 'outdoor'}
-        with self.assertNumQueries(8):
+        with self.assertNumQueries(9):
             response = self.client.patch(path, data, content_type='application/json')
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data['floorplan'], [])

tests/openwisp2/sample_connection/migrations/0001_initial.py

@@ -3,6 +3,7 @@
 import collections
 import uuid
 
+import django
 import django.db.models.deletion
 import django.utils.timezone
 import jsonfield.fields
@@ -14,7 +15,7 @@
 import openwisp_controller.connection.base.models
 import openwisp_users.mixins
 from openwisp_controller.connection import settings as connection_settings
-from openwisp_controller.connection.commands import COMMAND_CHOICES
+from openwisp_controller.connection.commands import COMMAND_CHOICES, get_command_choices
 
 
 class Migration(migrations.Migration):
@@ -245,7 +246,9 @@ class Migration(migrations.Migration):
                 (
                     'type',
                     models.CharField(
-                        choices=COMMAND_CHOICES,
+                        choices=COMMAND_CHOICES
+                        if django.VERSION < (5, 0)
+                        else get_command_choices,
                         max_length=16,
                     ),
                 ),

tests/openwisp2/sample_users/migrations/0001_initial.py

@@ -204,7 +204,12 @@ class Migration(migrations.Migration):
                 'verbose_name': 'user',
                 'verbose_name_plural': 'users',
                 'abstract': False,
-                'index_together': {('id', 'email')},
+                'indexes': [
+                    models.Index(
+                        fields=['id', 'email'],
+                        name='user_id_email_idx',
+                    )
+                ],
             },
             managers=[('objects', openwisp_users.base.models.UserManager())],
         ),