[tests] Fixed selenium tests

Author: pandafy

openwisp_controller/config/tests/test_selenium.py

@@ -1,11 +1,8 @@
+import ipdb
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase
 from django.test import tag
 from django.urls.base import reverse
-from selenium.common.exceptions import (
-    StaleElementReferenceException,
-    TimeoutException,
-    UnexpectedAlertPresentException,
-)
+from selenium.common.exceptions import TimeoutException
 from selenium.webdriver.common.action_chains import ActionChains
 from selenium.webdriver.common.alert import Alert
 from selenium.webdriver.common.by import By
@@ -117,9 +114,10 @@ def test_device_preview_keyboard_shortcuts(self):
     def test_unsaved_changes(self):
         self.login()
         device = self._create_config(organization=self._get_org()).device
-        self.open(reverse('admin:config_device_change', args=[device.id]))
+        path = reverse('admin:config_device_change', args=[device.id])
+        self.open(path)
         with self.subTest('Alert should not be displayed without any change'):
-            self.web_driver.refresh()
+            self.open(path)
             try:
                 WebDriverWait(self.web_driver, 1).until(EC.alert_is_present())
             except TimeoutException:
@@ -143,8 +141,7 @@ def test_unsaved_changes(self):
                     print(entry)
                 self.fail('Timed out wating for unsaved changes alert')
             else:
-                alert = Alert(self.web_driver)
-                alert.accept()
+                self.web_driver.switch_to.alert.accept()
 
     def test_multiple_organization_templates(self):
         shared_required_template = self._create_template(
@@ -176,7 +173,6 @@ def test_multiple_organization_templates(self):
             reverse('admin:config_device_change', args=[org1_device.id])
             + '#config-group'
         )
-        wait = WebDriverWait(self.web_driver, 2)
         # org2 templates should not be visible
         self.wait_for_invisibility(
             By.XPATH, f'//*[@value="{org2_required_template.id}"]'
@@ -253,16 +249,27 @@ def test_force_delete_device_with_deactivating_config(self):
 
         self.login()
         self.open(reverse('admin:config_device_change', args=[device.id]))
-        self.find_elements(by=By.CSS_SELECTOR, value='input.deletelink[type="submit"]')[
-            -1
-        ].click()
+        # The webpage has two "submit-row" sections, each containing a "Deactivate"
+        # button. The first (top) "Deactivate" button is hidden, causing
+        # `wait_for_visibility` to fail. To avoid this issue, we use
+        # `wait_for='presence'` instead, ensuring we locat the elements regardless
+        # of visibility. We then select the last (visible) button and click it.
+        self.find_elements(
+            by=By.CSS_SELECTOR,
+            value='input.deletelink[type="submit"]',
+            wait_for='presence',
+        )[-1].click()
         device.refresh_from_db()
         config.refresh_from_db()
         self.assertEqual(device.is_deactivated(), True)
         self.assertEqual(config.is_deactivating(), True)
 
         self.open(reverse('admin:config_device_change', args=[device.id]))
-        self.find_elements(by=By.CSS_SELECTOR, value='a.deletelink')[-1].click()
+        # Use `presence` instead of `visibility` for `wait_for`,
+        # as the same issue described above applies here.
+        self.find_elements(
+            by=By.CSS_SELECTOR, value='a.deletelink', wait_for='presence'
+        )[-1].click()
         self.wait_for_visibility(
             By.CSS_SELECTOR, '#deactivating-warning .messagelist .warning p'
         )
@@ -306,6 +313,7 @@ def test_force_delete_multiple_devices_with_deactivating_config(self):
         self.assertEqual(Device.objects.count(), 0)
 
 
+@tag('selenium_tests')
 class TestVpnAdmin(
     SeleniumTestMixin,
     CreateConfigTemplateMixin,
@@ -317,10 +325,8 @@ def test_vpn_edit(self):
         device, vpn, template = self._create_wireguard_vpn_template()
         self.open(reverse('admin:config_vpn_change', args=[vpn.id]))
         with self.subTest('Ca and Cert should not be visible'):
-            el = self.find_element(by=By.CLASS_NAME, value='field-ca')
-            self.assertFalse(el.is_displayed())
-            el = self.find_element(by=By.CLASS_NAME, value='field-cert')
-            self.assertFalse(el.is_displayed())
+            self.wait_for_invisibility(by=By.CLASS_NAME, value='field-ca')
+            self.wait_for_invisibility(by=By.CLASS_NAME, value='field-cert')
 
         with self.subTest('PrivateKey is shown in configuration preview'):
             self.find_element(by=By.CSS_SELECTOR, value='.previewlink').click()
@@ -335,7 +341,5 @@ def test_vpn_edit(self):
         with self.subTest('Changing VPN backend should hide webhook and authtoken'):
             backend = Select(self.find_element(by=By.ID, value='id_backend'))
             backend.select_by_visible_text('OpenVPN')
-            el = self.find_element(by=By.CLASS_NAME, value='field-webhook_endpoint')
-            self.assertFalse(el.is_displayed())
-            el = self.find_element(by=By.CLASS_NAME, value='field-auth_token')
-            self.assertFalse(el.is_displayed())
+            self.wait_for_invisibility(by=By.CLASS_NAME, value='field-webhook_endpoint')
+            self.wait_for_invisibility(by=By.CLASS_NAME, value='field-auth_token')

openwisp_controller/connection/static/connection/js/commands.js

@@ -27,7 +27,6 @@ django.jQuery(function ($) {
       timeoutInterval: 7000,
     },
   );
-  commandWebSocket.open();
   let selector = $("#id_command_set-0-type"),
     showFields = function () {
       var fields = $(
@@ -40,18 +39,24 @@ django.jQuery(function ($) {
         $("#command_set-2-group fieldset .dynamic-command_set-2:first");
         fields.show();
       }
+    },
+    init = function () {
+      showFields();
+      initCommandDropdown($);
+      initCommandOverlay($);
+      initCommandWebSockets($, commandWebSocket);
     };
   selector.change(function () {
     showFields();
   });
-
-  $("#id_command_set-0-input").one("jsonschema-schemaloaded", function () {
-    showFields();
-
-    initCommandDropdown($);
-    initCommandOverlay($);
-    initCommandWebSockets($, commandWebSocket);
-  });
+  if (django._schemas[$("#id_command_set-0-input").data("schema-url")]) {
+    // It is possible that the schema is loaded before the event handler
+    // is attached to the element. In that case, we need to manually call
+    // the init function.
+    init();
+  } else {
+    $("#id_command_set-0-input").one("jsonschema-schemaloaded", init);
+  }
 });
 
 function initCommandDropdown($) {
@@ -542,6 +547,7 @@ function initCommandOverlay($) {
 }
 
 function initCommandWebSockets($, commandWebSocket) {
+  commandWebSocket.open();
   commandWebSocket.addEventListener("message", function (e) {
     let data = JSON.parse(e.data);
     // Done for keeping future use of these websocket

openwisp_controller/connection/tests/test_selenium.py

@@ -1,12 +1,10 @@
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase
 from django.test import tag
 from django.urls import reverse
-import ipdb
 from selenium.webdriver.common.by import By
 from swapper import load_model
 
 from ...tests.utils import DeviceAdminSeleniumTextMixin
-
 from .utils import CreateConnectionsMixin
 
 Command = load_model('connection', 'Command')
@@ -43,10 +41,8 @@ def test_command_widget_on_device(self):
         self.wait_for_invisibility(By.CSS_SELECTOR, 'ul.object-tools a#send-command')
         self._create_device_connection(device=device, credentials=creds)
         self.assertEqual(device.deviceconnection_set.count(), 1)
-        import time; time.sleep(10)
         self.open(path)
         # Send reboot command to the device
-        # import ipdb; ipdb.set_trace()
         self.find_element(
             by=By.CSS_SELECTOR, value='ul.object-tools a#send-command', timeout=5
         ).click()

openwisp_controller/tests/test_selenium.py

@@ -90,7 +90,10 @@ def test_restoring_deleted_device(self, *args):
         # By checking that there are no WARNING level errors logged in the
         # browser console, we ensure that this issue is not happening.
         for error in self.get_browser_logs():
-            self.assertNotEqual(error['level'], 'WARNING')
+            if error['level'] == 'WARNING' and error['message'] not in [
+                'wrong event specified: touchleave'
+            ]:
+                self.fail(f'Browser console error: {error["message"]}')
         self.find_element(
             by=By.XPATH, value='//*[@id="device_form"]/div/div[1]/input[1]'
         ).click()

openwisp_controller/tests/utils.py

@@ -75,7 +75,6 @@ def tearDown(self):
                 pass
             else:
                 self.web_driver.switch_to_alert().accept()
-                self.web_driver.switch_to_alert.accept()
         self.web_driver.refresh()
         self.wait_for_visibility(By.XPATH, '//*[@id="site-name"]')